Received: from eggs.gnu.org ([2001:4830:134:3::10]:42958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTt2V-00016u-Sb for qemu-devel@nongnu.org; Tue, 16 Sep 2014 09:43:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTt2P-0002zs-P5 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 09:43:27 -0400 From: Markus Armbruster References: <20140915140934.17c1bfea@redhat.com> <87sijsxc1d.fsf@blackfin.pond.sub.org> <20140916083457.7512ef34@redhat.com> Date: Tue, 16 Sep 2014 15:43:14 +0200 In-Reply-To: <20140916083457.7512ef34@redhat.com> (Luiz Capitulino's message of "Tue, 16 Sep 2014 08:34:57 -0400") Message-ID: <87sijrk7f1.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel , qemu-stable@nongnu.org Luiz Capitulino writes: > On Tue, 16 Sep 2014 09:25:02 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > When a QMP client changes the polling interval time by setting >> > the guest-stats-polling-interval property, the interval value >> > is stored and manipuled as an int64_t variable. >> > >> > However, the balloon_stats_change_timer() function, which is >> > used to set the actual timer with the interval value, takes >> > an int instead, causing an overflow for big interval values. >> > >> > Fix it. >> > >> > Signed-off-by: Luiz Capitulino >> >> Subject claims buffer overflow, but description suggests integer >> overflow. Which one is it? > > Integer. Thanks. If you fix the subject, you can add my R-by.