Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mqt4u-00020i-9y for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:30:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mqt4p-0001yP-JX for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:30:03 -0400 Received: from [199.232.76.173] (port=58378 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mqt4p-0001yH-Dm for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:29:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42648) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mqt4o-0003Vh-WD for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:29:59 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8OITvE3004537 for ; Thu, 24 Sep 2009 14:29:58 -0400 Subject: Re: [Qemu-devel] [PATCH 06/13] convert pci bridge to qdev References: <1253611767-6483-1-git-send-email-kraxel@redhat.com> <1253611767-6483-7-git-send-email-kraxel@redhat.com> <20090923160200.GC18203@redhat.com> From: Markus Armbruster Date: Thu, 24 Sep 2009 20:29:56 +0200 In-Reply-To: <20090923160200.GC18203@redhat.com> (Michael S. Tsirkin's message of "Wed\, 23 Sep 2009 19\:02\:00 +0300") Message-ID: <87skecb3h7.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Gerd Hoffmann , qemu-devel@nongnu.org "Michael S. Tsirkin" writes: > On Tue, Sep 22, 2009 at 11:29:20AM +0200, Gerd Hoffmann wrote: >> @@ -890,15 +890,12 @@ PCIDevice *pci_find_device(int bus_num, int slot, int function) >> return bus->devices[PCI_DEVFN(slot, function)]; >> } >> >> -PCIBus *pci_bridge_init(PCIBus *bus, int devfn, uint16_t vid, uint16_t did, >> - pci_map_irq_fn map_irq, const char *name) >> +static int pci_bridge_initfn(PCIDevice *dev) > > pci_bridge_dev_init a better name? There's precedence for _initfn, _init1, and _init. I wish we'd pick one convention and stick to it. [...]