From: OGAWA Hirofumi Subject: Re: [PATCH] fat: make sure to set d_ops in fat_get_parent Date: Wed, 12 Nov 2008 06:03:56 +0900 Message-ID: <87skpyotz7.fsf@devron.myhome.or.jp> References: <20081111185123.GA11861@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:47497 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbYKKVLJ (ORCPT ); Tue, 11 Nov 2008 16:11:09 -0500 In-Reply-To: <20081111185123.GA11861@lst.de> (Christoph Hellwig's message of "Tue, 11 Nov 2008 19:51:23 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Christoph Hellwig writes: > fat_get_parent needs to setup the dentry operations, otherwise we might > lose them when the NFS server needs to reconnect out of cache inodes. > > > Signed-off-by: Christoph Hellwig > > Index: linux-2.6/fs/fat/inode.c > =================================================================== > --- linux-2.6.orig/fs/fat/inode.c 2008-11-08 10:47:12.000000000 +0100 > +++ linux-2.6/fs/fat/inode.c 2008-11-08 12:16:18.000000000 +0100 > @@ -749,6 +749,8 @@ static struct dentry *fat_get_parent(str > brelse(bh); > > parent = d_obtain_alias(inode); > + if (!IS_ERR(parent)) > + parent->d_op = sb->s_root->d_op; > out: > unlock_super(sb); Looks good. Thanks. -- OGAWA Hirofumi