Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD249ECAAD4 for ; Mon, 29 Aug 2022 09:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09CDB940009; Mon, 29 Aug 2022 05:25:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04CC5940007; Mon, 29 Aug 2022 05:25:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57FE940009; Mon, 29 Aug 2022 05:25:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D2BF4940007 for ; Mon, 29 Aug 2022 05:25:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AE1E816025C for ; Mon, 29 Aug 2022 09:25:25 +0000 (UTC) X-FDA: 79852097010.01.8B50E2D Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf19.hostedemail.com (Postfix) with ESMTP id BCCD01A0012 for ; Mon, 29 Aug 2022 09:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661765123; x=1693301123; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=6bjFxwLEsKLZFX2cLm7NlJwmIJ4DJEjhNXC6KOzn034=; b=mnB2VMvnBogJo/KY977NRkbaUXYuFnVQoSz4bV7irHNiuE1ON7dpDIRH K4G4RBUUuuawGB76ZuEsTake4y2vwPG/UCTSWJExbhybePeg2l9TqAm6O JVi9Rt5bQSjtn6qdgCa0TPRzgPFxuE2TwP//bZbzlppsoOYFM+WVtBqem aVD9SMhLr9xzkZvUo4mLTDvS5Xgfk3rPyEWdXJKQsWy/6LKzh5+7KTWss ezd5leeBOD7UKIQ22wU3COkOl6VqSpePojhGtOeUtYfuiBqWfuakL83lc gfj4eHyFfqnKapHe6BXPrzmOjdUrWF2MM9bRFmnJcX3L9Eiopi8dxNTTj w==; X-IronPort-AV: E=McAfee;i="6500,9779,10453"; a="292433487" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="292433487" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 02:25:22 -0700 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="640869351" Received: from idecesar-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.53.198]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 02:25:09 -0700 From: Jani Nikula To: Linus Torvalds , Dave Young Cc: David Hildenbrand , John Hubbard , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kexec@lists.infradead.org, Andrew Morton , Ingo Molnar , David Laight , Jonathan Corbet , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Baoquan He , Vivek Goyal , Stephen Johnston , Prarit Bhargava Subject: Re: [PATCH RFC 1/2] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel") In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220824163100.224449-1-david@redhat.com> <20220824163100.224449-2-david@redhat.com> <0db131cf-013e-6f0e-c90b-5c1e840d869c@nvidia.com> Date: Mon, 29 Aug 2022 12:25:02 +0300 Message-ID: <87tu5vflld.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=mnB2VMvn; spf=pass (imf19.hostedemail.com: domain of jani.nikula@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=jani.nikula@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661765125; a=rsa-sha256; cv=none; b=XlGtzIwDDz4UG8P0Sssae5UiYGkAFYv6sDU6MJsiAaZuXJKdNfLRsyqvVG+/pBIpvQ/jCq 615aLBfbVy+EeX7bWOzF0fyrllwTV6BG+r3kxq1feUWeyogOxop0ulHIaR8cAiHCY2j7Op dhYa1QuTIFF9ORWMw0o7BwV+JfdE4yM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661765125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YO/lluYngUxlnoZuwFPjlzLidglNiDxUjtQ5P1gv07Y=; b=k9jpVG6LYkxnpQIPIBD7TouwlV8AsqNcNpqaTUJvTGlJ3+rTSPOv3qtoQRncnXF84OOo/G w2pm1Ldgs2LtMXfgQhymXoPY3r+EaxyBFiZHaYuckxahYjKJx+3F3r8vBvFz1zqn5LMX1r XyYvpqfSLpjq7ViGtk/gXfXbIokMkec= Authentication-Results: imf19.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=mnB2VMvn; spf=pass (imf19.hostedemail.com: domain of jani.nikula@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=jani.nikula@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: acwbah5fnf1kq7ygrewqi3y8n1tfe387 X-Rspamd-Queue-Id: BCCD01A0012 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1661765123-981419 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 28 Aug 2022, Linus Torvalds wrote: > So WARN_ON_ONCE() is the thing to aim for. BUG_ON() is the thing for > "oops, I really don't know what to do, and I physically *cannot* > continue" (and that is *not* "I'm too lazy to do error handling"). Any insight for the tradeoff between WARN_ON_ONCE() and WARN_ON(), i.e. wasting the static once variable per use site vs. littering the dmesg on every hit? I see there have been some improvements with the __WARN_FLAGS() stuff, but is the data use really neglible? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center