Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F454C433EF for ; Fri, 20 May 2022 10:34:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L4NPy3zVMz3bsW for ; Fri, 20 May 2022 20:34:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=PsUQDWCl; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L4NPF5tVkz30DC for ; Fri, 20 May 2022 20:33:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=PsUQDWCl; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L4NPB05njz4xD8; Fri, 20 May 2022 20:33:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1653042830; bh=gh5EUZjLTVaelfDSvEhX92oWmuLejU9toBbSR9P8qD8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PsUQDWClI4L2G0cuBoB08pdGBKw7c/vqO+/K74WPdqFDNdtvjLF0hIvDrKvcsqtil MeCuMOOsYHyjre7owcj2S9NBvLAEjPWFRroa1VhfBsoHK1p4u2OTrqDdTtoff8wzvD gDOAuq6hHf1cIEvj6Lqr9gePfBJQaatg/HPF6JTu6UqAkjfIdU2IoJKM2GCklTeYDL 8ZrTy2xZ+mmNSbw1I09y14hRZv8Xj6KFx9hafceXg+4bGmAzN/nz5vwqS3CvnyHWXJ yzH3YMNUJq266BF/BW/LxZ8vjGdphsXgOUX4WJpLamUx8gd6pnEVUt1xFu/3Ipn5VZ mLAM+Y19vTrnA== From: Michael Ellerman To: Oliver O'Halloran Subject: Re: [PATCH] powerpc/powernv/pci: Drop VF MPS fixup In-Reply-To: References: <20200902035159.1762596-1-oohall@gmail.com> <23fd8d03-965b-a252-020e-4185c2ef5681@csgroup.eu> <871qwpofxr.fsf@mpe.ellerman.id.au> Date: Fri, 20 May 2022 20:33:45 +1000 Message-ID: <87tu9kmr1y.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" "Oliver O'Halloran" writes: > On Thu, May 19, 2022 at 10:38 PM Michael Ellerman wr= ote: >> Christophe Leroy writes: >> > Le 02/09/2020 =C3=A0 05:51, Oliver O'Halloran a =C3=A9crit : >> >> The MPS field in the VF config space is marked as reserved in current >> >> versions of the SR-IOV spec. In other words, this fixup doesn't do >> >> anything. >> >> >> >> Signed-off-by: Oliver O'Halloran >> > >> > A lot of cleanup patches from Oliver were merged in Septembre 2020 but >> > not this one. >> > >> > Any reason ? >> >> It wasn't clear to me that it's safe to remove. The commit that added it >> seemed to think it was important. >> >> The fact that it's out-of-spec doesn't mean we don't have some hardware >> somewhere that relies on that. > > There is no hardware that depends on it. It was added in response to a > bug report on the IBM internal bugzilla about virtual functions not > reporting the same MPS as the physical function in the output of > lspci. This is by design since MPS is a property that is only relevant > to the PF. There was a corresponding patch to skiboot to intercept > writes to the MPS field of VFs which was used to fake a writable MPS > field in firmware. I removed that hack in 2019 > (https://github.com/open-power/skiboot/commit/22057f868f3b2b1fd02647a738f= 6da0858b5eb6c) > since it was pointless and was causing other problems. There's no real > reason to keep this code around IMO. Thanks for the extra detail, I am persuaded :) cheers