Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iso8i-0005AZ-8q for mharc-qemu-trivial@gnu.org; Sat, 18 Jan 2020 08:27:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41505) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iso8e-00059F-SX for qemu-trivial@nongnu.org; Sat, 18 Jan 2020 08:27:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iso8c-0003YB-2c for qemu-trivial@nongnu.org; Sat, 18 Jan 2020 08:27:43 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33834 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iso8b-0003Ws-IX for qemu-trivial@nongnu.org; Sat, 18 Jan 2020 08:27:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579354060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N8w7064/FC54QWkO5c5dHGuWITtPCZOwiFG7Xt0RvIM=; b=RzsJXE7NLI0gWZSBuJRnXqjtIWxBIVlTeWH4fpp4xeHPGXbkXoaaNjzN1wBt7/88D9i4Qm KtEM3JvydOyD+xlXG1FQ30FMweIUEzG5AD5+7ukJ4Pt3pdAItz66BQ+EW0VMr1uBxnhV3e y7eiG3JsqnbbjHOvdG0Ztmu0DVpOLiM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-1xexDuVaOFmYeM89l3Fzow-1; Sat, 18 Jan 2020 08:27:39 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47D442F29; Sat, 18 Jan 2020 13:27:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-131.ams2.redhat.com [10.36.116.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76AA35C1B2; Sat, 18 Jan 2020 13:27:34 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 04BF91138600; Sat, 18 Jan 2020 14:27:33 +0100 (CET) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-trivial@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org Subject: Re: [PATCH] mailmap: Add more entries to sanitize 'git log' output References: <20191218185723.7738-1-philmd@redhat.com> <87h80ts0ii.fsf@dusky.pond.sub.org> Date: Sat, 18 Jan 2020 14:27:32 +0100 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Sat, 18 Jan 2020 09:17:42 +0100") Message-ID: <87tv4sq4hn.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 1xexDuVaOFmYeM89l3Fzow-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jan 2020 13:27:46 -0000 Philippe Mathieu-Daud=C3=A9 writes: > On 1/18/20 8:10 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daud=C3=A9 writes: >> >>> Most of these developers have the Signed-off-by tag properly >>> written, but not the author/commiter name. Fix this. >>> Also we incorrectly wrote Arei Gonglei name, update and reorder. >>> >>> git-log does not use this file by default until you specify the >>> --use-mailmap flag: >>> >>> $ git log --use-mailmap >>> >>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>> --- >>> .mailmap | 29 ++++++++++++++++++++++++++++- >>> 1 file changed, 28 insertions(+), 1 deletion(-) >>> >>> diff --git a/.mailmap b/.mailmap >>> index 3816e4effe..1a859d9e65 100644 >>> --- a/.mailmap >>> +++ b/.mailmap >>> @@ -56,6 +56,10 @@ Aaron Lindsay >>> Alexey Gerasimenko >>> Alex Ivanov >>> Andreas F=C3=A4rber >>> +Andreas F=C3=A4rber >>> +Andreas F=C3=A4rber >>> +Arei Gonglei >>> +Arei Gonglei >> >> I can't find this one in git-log. > > I was first surprised: > > $ git log -1 3b08098b40 > commit 3b08098b409c0fb28f85436ba1adeb1d401ec8f7 > Author: Gonglei > AuthorDate: Wed Dec 3 18:25:46 2014 +0000 > Commit: root > CommitDate: Mon Dec 22 14:39:21 2014 +0800 > > bootdevice: add validate check for qemu_boot_set() > > Signed-off-by: Gonglei > Reviewed-by: Markus Armbruster > > After thinking for a bit I remembered I once changed my default format: > > $ git config format.pretty > fuller Aha! Could've thought of this myself... > I suppose I should add this in the commit description. Can't hurt. [...] >>> Shin'ichiro Kawasaki >>> Shin'ichiro Kawasaki >>> +Siwei Zhuang >> >> It's actually spelled Siwei.Zhuang@data61.csiro.au in git-log. >> Shouldn't matter. > > Correct: > > $ git shortlog -e 6478dd745d~..6478dd745d > Zhuang, Siwei (Data61, Kensington NSW) (1)= : > hw/riscv: Add optional symbol callback ptr to riscv_load_kernel() > > $ git shortlog -e 6478dd745d~..6478dd745d > Siwei Zhuang (1): > hw/riscv: Add optional symbol callback ptr to riscv_load_kernel() Suggest to adjust case if you respin. > Thanks for caring checking all entries! Reviewed-by: Markus Armbruster [...]