From: Eric Anholt Subject: Re: [PATCH 1/6] drm/v3d: Document cache flushing ABI. Date: Mon, 03 Dec 2018 12:39:23 -0800 Message-ID: <87tvju1h1g.fsf@anholt.net> References: <20181201005759.28093-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dave Emett Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Spurden List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain Dave Emett writes: > On Mon, 3 Dec 2018 at 17:22, Dave Emett wrote: >> >> > + * The caches (L1T, slice, and L2T) will be flushed before the job >> > + * executes. The TLB writes are guaranteed to have been flushed by >> >> I would say before *each* job executes, as the caches are flushed >> before both bin and render. >> I wouldn't say "the caches" as not all of the V3D caches are flushed >> before executing a control list. In particular, the VCD cache is not >> cleared by the kernel driver (not even sure if there is a register >> interface to do this); it is expected that the control list will do >> this itself (using the CLEAR_VCD_CACHE instruction). >> On 3.3 and earlier there is a separate L2C for instructions/uniforms >> and a GCA. These do need to be flushed, and it looks like they are, so >> they should be mentioned here. > > Correction: on *3.2* and earlier there is a separate L2C for > instructions/uniforms. On 3.3 and earlier there is a GCA. > > It looks like we're currently unconditionally writing the L2C clear > registers. We should really only be doing this on 3.2 and earlier. OK, I've pushed the timeline name and tracing to drm-misc-next, and I'll resend the rest with more comments and the L2C change and outside-in invalidation once I'm far enough into this CTS run that I'm confident. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlwFlHwACgkQtdYpNtH8 nujd8w//VIM8lAGKBZpA/G+kCgc9iZXX0PjX5i45LST36VvTyCAKgZXG9CF/OWSY Sav8nz5nES0/tytM/jce8ScKw8xT30Uagp+fwa+fQlSkfFTCY1k+zTJXcTEJo7pe CUrXt8M8GJ891uMs05rKs+zb9+n1kV9mbpTZWrqeqfYNmBYG3dvjvx5rNGiAqssZ ayz77xI9NpViJ5p8/uLPuS4tXbnBWQyA7Z7giwlESIVIb5taPchhh26N4LklOc1q OxQ01NZSXHbOVZa6I7cebAh+KOrjfDSe+X0jm07uZZEVpZfHHaWY1ll/DaaKPQN+ TiTVt4VKfNrBAB6B9/y/rs9gBa/BWWiLNxDBL8xx4X+WVlwbOce1LYBt6SpFTAvr sWzlfKdDIeL4HdDxsARkAUrZndJytAWaDPw4rgd/ZqS/VpP35nZ6QC5E5+SgSHTo qmA4ieWqOjdB5f59WHuyJR6Ib7xnYkc4FSnc+w2z63sID7ZzXgI3SJ1YFffeWNNS rImJIpZDD1wXCnhvaZgkNLot8nry8S/lgOUq1G3wQLE492cnDeqL8XObsEo8p86j 6q7CsY+Y2NY1AUu3CKydLkZuKk8zq4AtQK1Ia0Oh20/pTRjjzMZN1eWDQ3/eXLu8 MAj+lmQw7v8zx5HqQb2f1sAJO/2wqTE5Z4gyHuOOjrksIbiTXcc= =tuaX -----END PGP SIGNATURE----- --=-=-=--