From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v2 2/7] x86/hyper-v: add a function to read both TSC and
 TSC page value simulateneously
Date: Mon, 15 Jan 2018 11:45:01 +0100
Message-ID: <87tvvnieoi.fsf@vitty.brq.redhat.com>
References: <20171213150945.24054-1-vkuznets@redhat.com>
 <20171213150945.24054-3-vkuznets@redhat.com>
 <alpine.DEB.2.20.1801142134370.2371@nanos>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Stephen Hemminger <sthemmin@microsoft.com>, kvm@vger.kernel.org,
 Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
 Haiyang Zhang <haiyangz@microsoft.com>, x86@kernel.org,
 linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
 "Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
 Ingo Molnar <mingo@redhat.com>, Roman Kagan <rkagan@virtuozzo.com>,
 Andy Lutomirski <luto@kernel.org>, "H.
 Peter Anvin" <hpa@zytor.com>, devel@linuxdriverproject.org,
 Mohammed Gamal <mmorsy@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
In-Reply-To: <alpine.DEB.2.20.1801142134370.2371@nanos> (Thomas Gleixner's
 message of "Sun, 14 Jan 2018 21:35:27 +0100 (CET)")
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>

Thomas Gleixner <tglx@linutronix.de> writes:

> On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
>
>> This is going to be used from KVM code where we need to get both
>> TSC and TSC page value.
>> 
>> When Hyper-V code is compiled out just return rdtsc(), this will allow us
>> to avoid ugly ifdefs in non-Hyper-V code.
>
> That's not what the patch implements....
>

Not anymore, thanks, will fix the description.

>> +static inline u64 hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg,
>> +				       u64 *cur_tsc)
>> +{
>> +	BUG();
>> +	return U64_MAX;
>> +}

-- 
  Vitaly