Received: from eggs.gnu.org ([2001:4830:134:3::10]:38439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8PPa-0001lL-07 for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:27:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8PPV-00041l-WF for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:27:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8PPV-00041g-PI for qemu-devel@nongnu.org; Mon, 14 Dec 2015 04:27:13 -0500 From: Markus Armbruster References: <1449768232-22924-1-git-send-email-armbru@redhat.com> <1449768232-22924-3-git-send-email-armbru@redhat.com> <5669B827.3090604@redhat.com> Date: Mon, 14 Dec 2015 10:27:10 +0100 In-Reply-To: <5669B827.3090604@redhat.com> (Laszlo Ersek's message of "Thu, 10 Dec 2015 18:36:39 +0100") Message-ID: <87twnlxtw1.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/4] error: Clean up errors with embedded newlines (again), part 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Pavel Fedin , qemu-devel@nongnu.org Laszlo Ersek writes: > On 12/10/15 18:23, Markus Armbruster wrote: >> The arguments of error_report() should yield a short error string >> without newlines. >> >> A few places try to print additional help after the error message by >> embedding newlines in the error string. That's nice, but let's do it >> the right way. Commit 474c213 cleaned up some, but they keep comint > > s/comint/coming/, you've been reading too many spy stories! :) Unfortunately, my demand for spy stories has been fully satisfied by the news. >> back. Offenders tracked down with the Coccinelle semantic patch from >> commit 312fd5f. > > My share of the blame is b86f46132 here... But you saw that patch! ;) Yes, but it never made it to the front of my review queue... > Anyway, this cleanup is consistent with your advice in > . > > Reviewed-by: Laszlo Ersek Thanks!