Received: from eggs.gnu.org ([2001:4830:134:3::10]:57871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVbAL-0002Bu-6j for qemu-devel@nongnu.org; Wed, 11 Mar 2015 03:34:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVbAH-00013t-SO for qemu-devel@nongnu.org; Wed, 11 Mar 2015 03:34:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVbAH-00013o-JU for qemu-devel@nongnu.org; Wed, 11 Mar 2015 03:34:49 -0400 From: Markus Armbruster References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <1423064635-19045-8-git-send-email-marcel@redhat.com> <54FF2EE0.9010401@suse.de> <20150310222233-mutt-send-email-mst@redhat.com> <54FF63F8.5030406@suse.de> Date: Wed, 11 Mar 2015 08:34:09 +0100 In-Reply-To: <54FF63F8.5030406@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Tue, 10 Mar 2015 22:36:56 +0100") Message-ID: <87twxsrnri.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, "Michael S. Tsirkin" , Marcel Apfelbaum , jan.kiszka@siemens.com, Riku Voipio , cornelia.huck@de.ibm.com, qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, scottwood@freescale.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net Andreas F=C3=A4rber writes: > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: >> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas F=C3=A4rber wrote: >>> Hi, >>> >>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: >>>> Fixes a QEMU crash when passing dump_guest_core parameter in command l= ine. >>> >>> Explain that, please? >>=20 >> Pls note the submission date. It's 1 month late to ask for >> basic clarifications. >>=20 >> I've merged the patches, I'll fix up issues such as prettifying >> includes by adding patches on top. > > No, since the patch is not in qemu.git (it builds!) it is not too late > to fix it, nor too late to ask why a patch that introduces a breakage > does what it does. Getting review that late is decidedly suboptimal, but no excuse to invoke maintainer privilege to ram the patch through unchanged. Cosmetic issues can be tidied up on top. The ongoing review may produce nothing but cosmetic issues, but we don't know that, yet. Commit messages can't be tidied up on top, and they're dirt cheap to improve right in place, so let's do that, please. [...]