Received: from eggs.gnu.org ([2001:4830:134:3::10]:40955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xc76L-00081k-3B for qemu-devel@nongnu.org; Thu, 09 Oct 2014 02:21:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xc76F-0004ve-OS for qemu-devel@nongnu.org; Thu, 09 Oct 2014 02:21:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xc76F-0004vS-H7 for qemu-devel@nongnu.org; Thu, 09 Oct 2014 02:21:19 -0400 From: Markus Armbruster References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1412244525-7153-1-git-send-email-imammedo@redhat.com> <1412683191.18043.7.camel@G08FNSTD140041> <20141007141018.546296f2@nial.usersys.redhat.com> <5433E961.6010207@suse.de> <20141007155321.36f9a3a7@nial.usersys.redhat.com> <1412740148.9352.7.camel@G08FNSTD140041> <5434EF71.8@redhat.com> <1412819414.4155.3.camel@G08FNSTD140041> Date: Thu, 09 Oct 2014 08:21:10 +0200 In-Reply-To: <1412819414.4155.3.camel@G08FNSTD140041> (Zhu Guihua's message of "Thu, 9 Oct 2014 09:50:14 +0800") Message-ID: <87tx3dg3vt.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua Cc: Peter Crosthwaite , Igor Mammedov , qemu-devel@nongnu.org, Bharata B Rao , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rb?= =?utf-8?Q?er?= Zhu Guihua writes: > On Wed, 2014-10-08 at 10:01 +0200, Paolo Bonzini wrote: >> Il 08/10/2014 05:49, Zhu Guihua ha scritto: >> > when device_add pc-dimm, only 'memdev' property is necessary, but the >> > 'id' property is optional.=20 >> >=20 >> > So I execute the command as followings: >> > object_add memory-backend-ram,id=3Dram0,size=3D128M >> > device_add pc-dimm,memdev=3Dram0 >> >=20 >> > Now it is impossible to delete the pc-dimm, because it has no id, and = it >> > is inside of 'peripheral-anon' container.=20 >>=20 >> Sure; but that was an explicit choice when you issued device_add. > > Thanks for your patient explanation=E3=80=82 > And I think it is better to make memory-devices without dev->id use > auto-generated IDs. Auto-generated IDs have been discussed and rejected several times. At the very least, clashes with user-specified IDs must be impossible.