From: Peter Korsgaard Date: Sat, 22 Feb 2014 21:40:54 +0100 Subject: [Buildroot] [PATCH 1/3] Makefile: internally use absolute paths to BR2_EXTERNAL In-Reply-To: <95fe8a6d-a049-4ff1-a33e-e5d282c07770@email.android.com> (Thomas De Schampheleire's message of "Sat, 22 Feb 2014 13:06:48 +0100") References: <95fe8a6d-a049-4ff1-a33e-e5d282c07770@email.android.com> Message-ID: <87txbqswx5.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Thomas" == Thomas De Schampheleire writes: > "Yann E. MORIN" schreef: >> From: "Yann E. MORIN" >> >> Using a relative path for BR2_EXTERNAL, and using an external defconfig, >> such as in (from a Buildroot top-dir): >> make O=.. BR2_EXTERNAL=.. foo_defconfig >> >> is broken. It is unclear why the %_defconfig rule recurses in that case. >> >> This patch internaly makes BR2_EXTERNAL canonical (ie. makes it an absolute >> path), and checks the directory exists. >> >> Reported-by: J?r?my Rosen >> Signed-off-by: "Yann E. MORIN" >> Cc: Peter Korsgaard >> Cc: Romain Naour >> Cc: Arnout Vandecappelle >> >> --- >> Changes v1->v2: >> - fix override BR2_EXTERNAL (J?r?my) >> - only one error message (Arnout) >> --- >> Makefile | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Makefile b/Makefile >> index 98d32c0..4766160 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -119,6 +119,11 @@ ifeq ($(BR2_EXTERNAL),) >> override BR2_EXTERNAL = support/dummy-external >> $(shell rm -f $(BR2_EXTERNAL_FILE)) >> else >> + _BR2_EXTERNAL = $(shell cd $(BR2_EXTERNAL) >/dev/null 2>&1 && pwd) >> + ifeq ($(_BR2_EXTERNAL),) >> + $(error BR2_EXTERNAL='$(BR2_EXTERNAL)' does not exist, relatively to $(TOPDIR)) > I think this should be 'relative to'. Committed with that changed, thanks. -- Bye, Peter Korsgaard