From: Peter Korsgaard Date: Mon, 04 Nov 2013 22:06:00 +0100 Subject: [Buildroot] [PATCH 2/2] libnl: do not allow to build tools on static lib configs In-Reply-To: <1383387986-9508-2-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sat, 2 Nov 2013 11:26:26 +0100") References: <1383387986-9508-1-git-send-email-thomas.petazzoni@free-electrons.com> <1383387986-9508-2-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <87txfrq3lz.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Thomas" == Thomas Petazzoni writes: > Building the libnl tools requires the header, which is not > compatible with static only builds. Therefore, this commit makes the > libnl tools option depend on !BR2_PREFER_STATIC_LIB. > Fixes: > http://autobuild.buildroot.org/results/573/57340b9bd2db3a523836e02e01cba6f7c17c8ca7/build-end.log > Signed-off-by: Thomas Petazzoni > --- > package/libnl/Config.in | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > diff --git a/package/libnl/Config.in b/package/libnl/Config.in > index fec10d3..be41b07 100644 > --- a/package/libnl/Config.in > +++ b/package/libnl/Config.in > @@ -6,11 +6,18 @@ config BR2_PACKAGE_LIBNL > http://people.suug.ch/~tgr/libnl/ > +comment "libnl needs a toolchain w/ threads" > + depends on !BR2_TOOLCHAIN_HAS_THREADS > + > +if BR2_PACKAGE_LIBNL > + > config BR2_PACKAGE_LIBNL_TOOLS > bool "install tools" > - depends on BR2_PACKAGE_LIBNL > + # uses > + depends on !BR2_PREFER_STATIC_LIB > help > Install binary tools. > -comment "libnl needs a toolchain w/ threads" > - depends on !BR2_TOOLCHAIN_HAS_THREADS > +comment "libnl tools need a toolchain w/ dynamic library" This comment should depend on BR2_PREFER_STATIC_LIB. -- Bye, Peter Korsgaard