From: Peter Korsgaard Date: Thu, 16 May 2013 20:54:09 +0200 Subject: [U-Boot] [PATCH v2 6/7] am335x_evm: Add support for the NOR module on the memory cape In-Reply-To: <20130516144641.GH32163@bill-the-cat> (Tom Rini's message of "Thu, 16 May 2013 10:46:41 -0400") References: <1368469719-22406-1-git-send-email-trini@ti.com> <1368469719-22406-6-git-send-email-trini@ti.com> <8738tnngf9.fsf@dell.be.48ers.dk> <20130516144641.GH32163@bill-the-cat> Message-ID: <87txm2n4by.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >>>>> "Tom" == Tom Rini writes: Hi, >> Perhaps the nand handling should just get moved out of gpmc_init() (or >> the _cs_config args should be passed to gpmc_init() ). Tom> I looked at this, on the scale of redoing omap3 too (where we have a lot Tom> of existing examples). The split we've got now works and it's harmless Tom> to re-configure CS0 in the case where the defaults don't work. I think Tom> this would lead us to an abstraction that leads to a lot of board files Tom> duplicating the same code. Maybe the solution is simply to have: init_gpmc_nand() and init_gpmc_nor() ? -- Bye, Peter Korsgaard