Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ICb26-0005ZP-JW for mharc-grub-devel@gnu.org; Sun, 22 Jul 2007 08:59:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ICb25-0005ZK-0H for grub-devel@gnu.org; Sun, 22 Jul 2007 08:59:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ICb24-0005Z7-IH for grub-devel@gnu.org; Sun, 22 Jul 2007 08:59:32 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICb24-0005Z4-EG for grub-devel@gnu.org; Sun, 22 Jul 2007 08:59:32 -0400 Received: from smtp-vbr11.xs4all.nl ([194.109.24.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ICb23-0001PL-O0 for grub-devel@gnu.org; Sun, 22 Jul 2007 08:59:32 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr11.xs4all.nl (8.13.8/8.13.8) with ESMTP id l6MCxUbE001924 for ; Sun, 22 Jul 2007 14:59:30 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20070625121637.GA19912@ws3.vdp.com> <20070627113523.GA16441@ws3.vdp.com> <20070628035658.GA12179@ws3.vdp.com> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 22 Jul 2007 15:01:04 +0200 In-Reply-To: <20070628035658.GA12179@ws3.vdp.com> (bean123@126.com's message of "Thu, 28 Jun 2007 11:56:58 +0800") Message-ID: <87tzrwfv8v.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: [PATCH] bug fix for scripting (update 3) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2007 12:59:33 -0000 Bean writes: > This update includes u2 and u2-1, and fix a small problem caused by u2-2. Oh, I should've waited with the other reviews until I noticed this one. > -- > Bean > > 2007-06-28 Bean > > * kern/parser.c (state_transitions): Exit GRUB_PARSER_STATE_VARNAME > state when "/" is encountered. Which problem does it solve? At first sight, this looks ok. If it fixes something that is ;-). > * normal/execute.c (grub_script_argument_to_string): Check for > undefined variable. ok > * normal/execute.c (grub_script_execute_cmdline): Reset grub_errno. ok. > * normal/main.c (read_config_file): Reset grub_errno. ok. > * normal/lexer.c (grub_script_yylex2): Construct arg structure when > mixed text is detected. Please leave this out for now. > * normal/lexer.c (check_textstate): Add GRUB_PARSER_STATE_ESC. Can you explain this? Is this for Stuff\ Like\ This? :-) > * normal/parser.y : Change attribute of token GRUB_PARSER_TOKEN_VAR. Please leave this out for now. Thanks, Marco