Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 370B437B71 for ; Tue, 6 Jun 2023 13:39:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 26C4D1FD5F; Tue, 6 Jun 2023 13:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686058784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=462N3FUOdYKZv5klJJlq8qn2E+eAQyYPufKvS8K1hzY=; b=Zz66Txsl+K0h46u7myvm5DnhCY+xPElI6UTObP03mw8KGm7+SGOX3DtoB+kXp9onuM22yT +F/zY24CGM50fAT6UinKY+yK3HQdjLZ5i0o5xUt7uTjvAMzrIrRa3qrZzUxYCQOdaFgZ3/ UgeIpK4ZBqBfU09x8q5YsK/TYzWGdbY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686058784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=462N3FUOdYKZv5klJJlq8qn2E+eAQyYPufKvS8K1hzY=; b=z3sYPSSkXavp/ZYI9IHPbmYQAIgpXrBLFwHeBQXM5MyY20TJRRto6Ad6CPznOd6jU5nbuD WZ7SAtJaRSyBlWBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EABF313776; Tue, 6 Jun 2023 13:39:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PWtaOB83f2SuYgAAMHmgww (envelope-from ); Tue, 06 Jun 2023 13:39:43 +0000 Date: Tue, 06 Jun 2023 15:39:43 +0200 Message-ID: <87v8g0g15s.wl-tiwai@suse.de> From: Takashi Iwai To: Yanteng Si Cc: tiwai@suse.com, perex@perex.cz, chenhuacai@loongson.cn, alsa-devel@alsa-project.org, loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn, Yingkun Meng Subject: Re: [PATCH v2 3/4] ALSA: hda: Workaround for SDnCTL register on loongson controller In-Reply-To: <5e1de6145ad6fd32814165f596be38ef03137c8d.1686057365.git.siyanteng@loongson.cn> References: <5e1de6145ad6fd32814165f596be38ef03137c8d.1686057365.git.siyanteng@loongson.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Tue, 06 Jun 2023 15:25:29 +0200, Yanteng Si wrote: > > On loongson controller, after calling snd_hdac_stream_updateb() > to enable DMA engine, the SDnCTL.STRM will become to zero. We > need to access SDnCTL in dword to keep SDnCTL.STRM is not changed. > > Signed-off-by: Yanteng Si > Signed-off-by: Yingkun Meng > --- > include/sound/hdaudio.h | 1 + > sound/hda/hdac_stream.c | 6 +++++- > sound/pci/hda/hda_intel.c | 1 + > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h > index a1dcc7f97d08..859becb0eaba 100644 > --- a/include/sound/hdaudio.h > +++ b/include/sound/hdaudio.h > @@ -348,6 +348,7 @@ struct hdac_bus { > bool polling_mode:1; > bool no_intr_polling_mode:1; > bool needs_damn_long_delay:1; > + bool access_sdnctl_in_dword:1; It's worth for the comment here, too. thanks, Takashi