Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52BAAC433F5 for ; Mon, 7 Mar 2022 21:04:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C70E160EDD; Mon, 7 Mar 2022 21:04:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 20Q24zqZ-Vq4; Mon, 7 Mar 2022 21:04:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 0676D60736; Mon, 7 Mar 2022 21:04:51 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D3C381BF2C3 for ; Mon, 7 Mar 2022 21:04:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C347840210 for ; Mon, 7 Mar 2022 21:04:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id toN8UdKQpT04 for ; Mon, 7 Mar 2022 21:04:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by smtp4.osuosl.org (Postfix) with ESMTPS id DF067401DC for ; Mon, 7 Mar 2022 21:04:49 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 6EFA6240004; Mon, 7 Mar 2022 21:04:45 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1nRKX6-001HNv-Vs; Mon, 07 Mar 2022 22:04:44 +0100 From: Peter Korsgaard To: References: <19116_1644506970_62052F5A_19116_77_1_cb2a6466cea018c4bf8b8877140a9f389bb7918f.1644506959.git.yann.morin@orange.com> Date: Mon, 07 Mar 2022 22:04:44 +0100 In-Reply-To: <19116_1644506970_62052F5A_19116_77_1_cb2a6466cea018c4bf8b8877140a9f389bb7918f.1644506959.git.yann.morin@orange.com> (yann morin's message of "Thu, 10 Feb 2022 16:29:24 +0100") Message-ID: <87v8wp4gpf.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/5 v3] package/pkg-cargo: allow packages to define download environment X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> writes: > From: "Yann E. MORIN" > Currently, the cargo infrastructure forcibly sets the package _DL_ENV > variable, instead of appending to it, which prevents packages from > providing their own download environment variables. > We fix that by using an append-assignment. > Note: when introduced, that variable was explicitly not documented, and > is supposed to only be used by packages infrastructures. However, that > variable exists, and it can be (ab)used by br2-external packages (most > probably to ill effects, but heh!). We anyway leave it undocumented, > like _ROOTFS_PRE_CMD_HOOKS. > Signed-off-by: Yann E. MORIN > Cc: Thomas Petazzoni > Acked-by: Thomas Petazzoni Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot