Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADDCC43464 for ; Mon, 21 Sep 2020 07:32:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DEC420874 for ; Mon, 21 Sep 2020 07:32:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iPOSmnmm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DEC420874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKGJh-0002wc-W3 for qemu-devel@archiver.kernel.org; Mon, 21 Sep 2020 03:32:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKGIy-0002P2-Kq for qemu-devel@nongnu.org; Mon, 21 Sep 2020 03:32:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKGIv-0002Sm-8T for qemu-devel@nongnu.org; Mon, 21 Sep 2020 03:32:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600673522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cLzUdlT6NbmhexNVcEtUqH2U6/hcCqt0eA/eZPT11Wo=; b=iPOSmnmm1Lb9mX2tbRh+TyZq4UGh6Hs0ruIvuVglyz9Qdg8buqFZ4bp9iYlxH6sSdVHsBd zxLcDfvz6KPdD0vm1VPfdQX7gAzOQE6gCmD8HWIniXK+BAAU/jJv8wstBGHmRtXrUFDts9 leJtu1NWRDCn/uKcx66X53vxoa1R2Ng= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-JL2u5Pp4MdeVJf7HT_fw8A-1; Mon, 21 Sep 2020 03:31:57 -0400 X-MC-Unique: JL2u5Pp4MdeVJf7HT_fw8A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97159100945B; Mon, 21 Sep 2020 07:31:56 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5034478825; Mon, 21 Sep 2020 07:31:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C65041132E9A; Mon, 21 Sep 2020 09:31:54 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 06/37] qapi: delint using flake8 References: <20200915224027.2529813-1-jsnow@redhat.com> <20200915224027.2529813-7-jsnow@redhat.com> <87wo0tor80.fsf@dusky.pond.sub.org> <8238685e-f4a4-cf2f-2511-5e4473f5fdd3@redhat.com> <87a6xog7n8.fsf@dusky.pond.sub.org> <82b4b8ce-b348-75fd-bd44-d96303a4875d@redhat.com> <87bli3jrwy.fsf@dusky.pond.sub.org> <631e465a-a0e8-4e92-482d-bc92bba6f5bf@redhat.com> Date: Mon, 21 Sep 2020 09:31:54 +0200 In-Reply-To: <631e465a-a0e8-4e92-482d-bc92bba6f5bf@redhat.com> (John Snow's message of "Fri, 18 Sep 2020 14:13:58 -0400") Message-ID: <87v9g7a8lx.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 01:44:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.501, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > On 9/18/20 6:33 AM, Markus Armbruster wrote: >> John Snow writes: [...] >>> Embedded templates are always gonna look kinda nasty, I think, because >>> you're trying to fight style guidelines in two languages >>> simultaneously and it's never gonna quite work out exactly how you >>> want without some pretty complex abstraction mechanisms that are well >>> beyond the power we need right now. >> The thought "screw this, pile the output through /usr/bin/indent" >> has >> crossed my mind more than once. >> > > Bigger fish to fry, but with other languages like rust looming, making > the core generation facilities nicer might be ...nice. Not for this > series. Definitely not. The way we generate C now is (close to) the stupidest way that could possibly work. Stupid is *good*, until it creates actual problems. Any improvement will have to balance readability vs. hackability. What we have now is often hard to read, but pretty easy to hack. May sound like a contradiction, but it's been my experience. > Two approaches in general would make sense to me: > > 1. Building an AST for C instead of strings, and rendering the AST. I fear the need to define an AST for C makes this uneconomical. I've missed the ease of generating Lisp in Lisp many times. > 2. Writing a templating engine that doesn't break the Python > indentation flow by hoisting them into module constants and improving > the rendering logic. Too vague for me to judge, happy to look at PoC patches.