From: Eric Anholt Subject: Re: [PATCH v3 3/3] drm/panfrost: Add initial panfrost driver Date: Tue, 09 Apr 2019 14:25:53 -0700 Message-ID: <87v9zmdg66.fsf@anholt.net> References: <20190409205427.6943-1-robh@kernel.org> <20190409205427.6943-4-robh@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0160070135==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 2993C89206 for ; Tue, 9 Apr 2019 21:25:56 +0000 (UTC) In-Reply-To: <20190409205427.6943-4-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring , dri-devel@lists.freedesktop.org Cc: Tomeu Vizoso , Neil Armstrong , Maxime Ripard , linux-kernel@vger.kernel.org, David Airlie , "Marty E . Plummer" , Sean Paul , Alyssa Rosenzweig List-Id: dri-devel@lists.freedesktop.org --===============0160070135== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Rob Herring writes: > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 and > T760 Midgard GPUs have been tested. > +static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data, > + struct drm_file *file_priv) > +{ > + struct drm_panfrost_get_bo_offset *args = data; > + struct drm_gem_object *gem_obj; > + struct panfrost_gem_object *bo; > + Missing check for pad == 0. With that fixed, Reviewed-by: Eric Anholt > + gem_obj = drm_gem_object_lookup(file_priv, args->handle); > + if (!gem_obj) { > + DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle); > + return -ENOENT; > + } > + bo = to_panfrost_bo(gem_obj); > + > + args->offset = bo->node.start << PAGE_SHIFT; > + > + drm_gem_object_put_unlocked(gem_obj); > + return 0; > +} > +static void panfrost_job_timedout(struct drm_sched_job *sched_job) > +{ > + struct panfrost_job *job = to_panfrost_job(sched_job); > + struct panfrost_device *pfdev = job->pfdev; > + int js = panfrost_job_get_slot(job); > + int i; > + > + /* > + * If the GPU managed to complete this jobs fence, the timeout is > + * spurious. Bail out. > + */ > + if (dma_fence_is_signaled(job->done_fence)) > + return; Note: The scheduler calls cancel_delayed_work_sync() in s_job->finish_work, so this is just reducing the race for the job successfully completing near the timeout but finish_work being in the workqueue across the timeout boundary. I dropped it from v3d. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlytDeEACgkQtdYpNtH8 nuh3JRAAtq3pl35Q1d7+I6lbFCjyLdVHXmNShOpudBRqlPvTkKycYdhWyeUHIyRj GVDmnaFUdQURCYWr64mqcsqu6U/N/pIAyttRVqxb4qp67Z403BZOC+BlJ1EAJgNv vzJHUZfSZtyRrF4pez1uyY44pKbAY9ERxvYORhN4QnHfnG9h973fsHaeAD0Yjcv7 nm8yGthWiH3Tn7rqIwRmMVWJf0nhs24QLpjHZSTe7Tsbpb6jcN/nnzkPEgd5XxAm aP75lVGfMnzISrvC1fJV4hwalMlJaXQFEP2cknDdB7mLcwh7ImrDwxCaMQwh/eB3 dpMBpbr73CM5lvgbacG30PLrr3SNlVkS5XerqqmSxWbFnvQnBbeWiLUaCPzRHerw SMAMZq2ML2nfn2eGpipQ7EIRmhZHM6lTJsViEPHIiGrdKUUeR4L+guKMlqGjaJ0F n3Vsw+neyW62lIbD82L5vblZB0KMB50In7Mje0wrF9qncCT6qnYNvGa7NPeJcOJ9 fhLsa2rbX9EoeGK4tLHQrdzcfNVz/FzmNhhGom1ifw+fa4llhdLAxUstn2mpP6sl PSCwgdmahlQAa1PciacTQHrVWw2lQDnPzcvn9+MApG2mbIqPZF9khCrbbRgmIXI5 8dnMFLTWue7UBLXMEVerxahEVe5Srnj3I34lk5eSa9M0ohcccvA= =7SIf -----END PGP SIGNATURE----- --=-=-=-- --===============0160070135== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0160070135==--