Received: from eggs.gnu.org ([209.51.188.92]:35930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1WgL-0006Po-0p for qemu-devel@nongnu.org; Wed, 06 Mar 2019 08:34:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1WgK-0007qy-4n for qemu-devel@nongnu.org; Wed, 06 Mar 2019 08:34:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1WgJ-0007qN-V1 for qemu-devel@nongnu.org; Wed, 06 Mar 2019 08:34:00 -0500 From: Markus Armbruster References: <20190305162829.20079-1-philmd@redhat.com> <11d78ce4-4646-ca1d-82a6-3db98298996b@redhat.com> Date: Wed, 06 Mar 2019 14:33:53 +0100 In-Reply-To: <11d78ce4-4646-ca1d-82a6-3db98298996b@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 6 Mar 2019 10:21:21 +0100") Message-ID: <87va0wxh32.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/5] mips_malta: Clean up definition of flash memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Aleksandar Markovic , Alex =?utf-8?Q?Ben?= =?utf-8?Q?n=C3=A9e?= , Aleksandar Rikalo , Aurelien Jarno , "qemu-devel@nongnu.org" , Aleksandar Markovic Philippe Mathieu-Daud=C3=A9 writes: > Hi Aleksandar, > > On 3/6/19 7:38 AM, Aleksandar Markovic wrote: >> On Tuesday, March 5, 2019, Philippe Mathieu-Daud=C3=A9 > > wrote: >>=20 >> Hi Markus, >>=20 >> this is a rework of your 'mips_malta: Clean up definition of flash >> memory size somewhat' patch: >> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07177.html >> >>=20 >> Regards, >>=20 >> Phil. >>=20 >>=20 >> Philippe, >>=20 >> Could you summarize end-user-visible changes resulting from this series? > > Good maintainer reflex :) > > There is an end-user visible change, if he provides a file that is not > exactly 4MiB he will now get a "Malta CoreLV card expects a bios of 4MB" > error message and QEMU will exit to his shell. This change is introduced > by patch 4/5. > > Now I rather expect this series to get integrated in Markus current > work, because his subsequent patches change the PFlash API and it is > easier he takes this (to avoid merge conflicts). Definitely. > Note: Markus series is expected to include the following patch from Alex > Benn=C3=A9e: "hw/block: better reporting on pflash backing file mismatch" > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07341.html > which is a more important user visible change. I think the the changelog > can be updated once, by Markus :) Yes. > Meanwhile, if this series is taken by Markus can I have your Ack-by? > > Thanks, > > Phil.