Received: from eggs.gnu.org ([2001:4830:134:3::10]:38577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsCSm-0003J1-SB for qemu-devel@nongnu.org; Fri, 30 Oct 2015 12:23:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsCSh-00017m-V1 for qemu-devel@nongnu.org; Fri, 30 Oct 2015 12:23:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsCSh-00017O-Pk for qemu-devel@nongnu.org; Fri, 30 Oct 2015 12:23:31 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A3610C1A0BDB for ; Fri, 30 Oct 2015 16:23:30 +0000 (UTC) From: Markus Armbruster References: <1446217682-24421-1-git-send-email-ehabkost@redhat.com> Date: Fri, 30 Oct 2015 17:23:27 +0100 In-Reply-To: <1446217682-24421-1-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 30 Oct 2015 13:07:51 -0200") Message-ID: <87vb9o9vgg.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Andrew Jones , qemu-devel@nongnu.org Eduardo Habkost writes: > Changes v2 -> v3: > * Removed patch: "vl.c: Convert error sentences to simpler phrases" > * Removed patch: "vl.c: Reword -machine help error messages" > * Removed patch: "vl.c: Reword fw_cfg name prefix warning" > * Removed patch: "vl.c: Use US spelling for 'unrecognized'" > * New patch: "vl.c: Change 'fail to parse' error message to 'failed to parse'" > * Squashed "vl.c: trivial: Don't wrap lines unnecessarily" > into "vl.c: Replace fprintf(stderr) with error_report()" > > Changes v1 -> v2: > * Extra patches for many suggestions I got when changing vl.c to use > error_report() > > Eduardo Habkost (11): > vl.c: Replace fprintf(stderr) with error_report() > vl.c: Use error_report() when reporting shutdown signal > vl.c: Remove periods and exclamation points from error messages > vl.c: Use "warning:" prefix consistently on warnings > vl.c: Use "cannot" instead of "can not" in error messages > vl.c: Use 'quotes' instead of `quotes' in messages > vl.c: Remove unnecessary uppercase in error messages > vl.c: Change "fail to parse" error message to "failed to parse" > vl.c: Simplify "ignoring deprecated option" warnings > vl.c: Reword -no-kvm-pit-reinjection deprecation warning > vl.c: Use "%s support is disabled" error messages consistently > > vl.c | 256 +++++++++++++++++++++++++++++++++---------------------------------- > 1 file changed, 125 insertions(+), 131 deletions(-) I guess I would've squashed some of these together, and perhaps touched up the rest of the files listed in MAINTAINERS under "Main loop", too (cpus.c main-loop.c qemu-timer.c). Regardless, this looks ready to go through my tree.