Received: from eggs.gnu.org ([2001:4830:134:3::10]:39719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsUFX-0000Wx-Jr for qemu-devel@nongnu.org; Wed, 13 May 2015 06:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsUFT-0000Ly-9F for qemu-devel@nongnu.org; Wed, 13 May 2015 06:50:51 -0400 From: Markus Armbruster References: <1431446962-9860-1-git-send-email-berrange@redhat.com> <1431446962-9860-5-git-send-email-berrange@redhat.com> <55524755.4010301@redhat.com> <20150513080906.GB23627@redhat.com> Date: Wed, 13 May 2015 12:50:38 +0200 In-Reply-To: <20150513080906.GB23627@redhat.com> (Daniel P. Berrange's message of "Wed, 13 May 2015 09:09:06 +0100") Message-ID: <87vbfwoio1.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org "Daniel P. Berrange" writes: > On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: >> On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: >> > The qemu-io tool does not check if the image is encrypted so >> > historically would silently corrupt the sectors by writing >> > plain text data into them instead of cipher text. The earlier >> > commit turns this mistake into a fatal abort, so check for >> > encryption and prompt for key when required. >> >> Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3 >> patches? Should this be rearranged so that 1/5 comes after this to >> avoid triggering the abort? > > I'm ambivalent on that - previously qemu-io was data corrupting > for this scenario, so crashing isn't really that much worse :-) If it crashes before it can corrupt anything, I'd sell it as an improvement ;) [...]