From: eric@anholt.net (Eric Anholt) Date: Wed, 29 Apr 2015 09:39:23 -0700 Subject: [PATCH 1/3 v5] dt/bindings: Add binding for the BCM2835 mailbox driver In-Reply-To: <55403446.1040207@wwwdotorg.org> References: <1430173644-19099-2-git-send-email-eric@anholt.net> <1430253868-11138-1-git-send-email-eric@anholt.net> <55403446.1040207@wwwdotorg.org> Message-ID: <87vbgeq478.fsf@eliezer.anholt.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Stephen Warren writes: > On 04/28/2015 02:44 PM, Eric Anholt wrote: >> From: Lubomir Rintel >> >> Signed-off-by: Lubomir Rintel >> Signed-off-by: Craig McGeachie >> Signed-off-by: Eric Anholt >> Acked-by: Lee Jones >> Acked-by: Stephen Warren >> --- >> >> v2: Split into a separate patch for submitting to the devicetree list. >> Consistently start node docs with a capital letter. device's >> address in the example shouldn't have "0x". Drop machine-specific >> interrupt numbers from the docs. (changes by anholt). >> >> v3: Move the file to just bcm2835-mbox.txt, clean up formatting >> (changes by anholt, from review by Lee Jones). >> >> v4: Move file back by consensus from various Broadcom platform >> maintainers (changes by anholt, acked by Lee Jones). >> >> v5: Document that the mailbox cell should be 0 in clients, and add an >> example of a client (changes by anholt, from review by Jassi). > > Some mention of what you changed in the patch might be nice, since it > was originally authored by someone else, and there's quite a changelog. I've been taking this changelog stuff out of the patch and putting it below '---' because when I was submitting this series before, I got chided for putting it in the patch! >> diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt > >> +- #mbox-cells: Specifies the number of cells needed to encode a mailbox >> + channel. The value shall be 1. Clients should supply a value >> + of 0 for the mailbox channel, because there is only one >> + exposed > > Can't you use #mbox-cells = <0> if there's no data to provide? of_mbox_index_xlate looks like it's always dereferencing the first arg. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 818 bytes Desc: not available URL: