Return-Path: From: Sven Joachim To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ding Tianhong , Eric Dumazet , "David S. Miller" Subject: Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL References: <20130402221104.163133110@linuxfoundation.org> <20130402221116.307254752@linuxfoundation.org> Date: Wed, 03 Apr 2013 13:41:32 +0200 In-Reply-To: <20130402221116.307254752@linuxfoundation.org> (Greg Kroah-Hartman's message of "Tue, 2 Apr 2013 15:11:27 -0700") Message-ID: <87vc833kpf.fsf@turtle.gmx.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and 3.9-rc5: "udevd[56]: sender uid=65534, message ignored". Reverting the patch below on top of 3.8.6-rc1 fixes that. I'm using udev version 175 here, and 65534 is the uid of user "nobody". Cheers, Sven > From: dingtianhong > > [ Upstream commit 14134f6584212d585b310ce95428014b653dfaf6 ] > > SCM_SCREDENTIALS should apply to write() syscalls only either source or destination > socket asserted SOCK_PASSCRED. The original implememtation in maybe_add_creds is wrong, > and breaks several LSB testcases ( i.e. /tset/LSB.os/netowkr/recvfrom/T.recvfrom). > > Origionally-authored-by: Karel Srot > Signed-off-by: Ding Tianhong > Acked-by: Eric Dumazet > Signed-off-by: David S. Miller > Signed-off-by: Greg Kroah-Hartman > --- > net/unix/af_unix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/net/unix/af_unix.c > +++ b/net/unix/af_unix.c > @@ -1414,8 +1414,8 @@ static void maybe_add_creds(struct sk_bu > if (UNIXCB(skb).cred) > return; > if (test_bit(SOCK_PASSCRED, &sock->flags) || > - !other->sk_socket || > - test_bit(SOCK_PASSCRED, &other->sk_socket->flags)) { > + (other->sk_socket && > + test_bit(SOCK_PASSCRED, &other->sk_socket->flags))) { > UNIXCB(skb).pid = get_pid(task_tgid(current)); > UNIXCB(skb).cred = get_current_cred(); > }