From: Peter Korsgaard Date: Fri, 22 Feb 2013 14:24:55 +0100 Subject: [Buildroot] [PATCH 1/1] libmad: force architecture-specific optimisations on AVR32 In-Reply-To: (Simon Dawson's message of "Fri, 22 Feb 2013 08:21:49 +0000") References: <1361494881-27134-1-git-send-email-gilles.talis@gmail.com> Message-ID: <87vc9keb14.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Simon" == Simon Dawson writes: Simon> Hi Gilles, Simon> On 22 February 2013 01:01, Gilles Talis wrote: >> Fixes: >> http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22 >> http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5d >> >> Signed-off-by: Gilles Talis Simon> This looks fine, but wouldn't it be simpler to just do Simon> config BR2_PACKAGE_LIBMAD Simon> bool "libmad" Simon> select BR2_PACKAGE_LIBMAD_ASO if BR2_avr32 Simon> in the libmad Config.in? Indeed. That or simply hiding (forcing) the option on avr32, E.G.: config BR2_PACKAGE_LIBMAD_ASO bool "Architecture-specific optimizations" if !BR2_avr32 default y -- Bye, Peter Korsgaard