Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6A827C6CD for ; Thu, 29 Feb 2024 13:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213341; cv=none; b=dLCRjoMus0A5pKZq7dS2k3xFR0/Skc7jIOQD13Hjtrt+CGZ2v8eaezQ5DJDRpr9lC9AoaXzvLpj5EGvTqMQiyk++RFf1mn+Q8Wq65a3W/xySwO0ZbK2WyuPtcGo6sGwPlCOFv8BFIdTBesakRtHbWbl/CQaKfbZ0dsSWEswFL6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213341; c=relaxed/simple; bh=qC/BHsDZtaJSaZeAWiihKc4UXcjJYv/Wmwe7fQ+6fdQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HQuugbW7Dyx/NchIx5Rdjil6RORyKloQJpitpyUQrcPERgCBoQKejcXbK9EOJlnZm9QFERmqb9IOe4mZzLKn9YhWoX0rjZvuiCvtokIt+47SL2WRSu9xQng+wPWEgKd/y3o2XZ9mIfFt/CnQDsyGQD56+zdH/5X9ijcHKGKg09E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EsDjt+HY; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EsDjt+HY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709213338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WnQPnqAt3BZw9D26tvLnsVZaWFXrJYHmtq+zViDCJHQ=; b=EsDjt+HYmynnR4mPWQh74+nqMSXwXniNqY0hFOTyjX4rc7nBShJqRMrKfPbeMP782d2JuL 3WKz21MlyETDokl0pW15ANZ130Ks7L+9b+NDGzpdLiKEoI63e4Nr30M1AaZCjXg8Jkscza NfW1vKsYuIJGANJblLsQcV/RmnvfxfU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-bosJRe1EPT6tKL6wtdY0dw-1; Thu, 29 Feb 2024 08:28:53 -0500 X-MC-Unique: bosJRe1EPT6tKL6wtdY0dw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A04683106F; Thu, 29 Feb 2024 13:28:52 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 244391BDB1; Thu, 29 Feb 2024 13:28:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 16D0621E66D0; Thu, 29 Feb 2024 14:28:51 +0100 (CET) From: Markus Armbruster To: Xiaoyao Li Cc: Markus Armbruster , Paolo Bonzini , David Hildenbrand , Igor Mammedov , Eduardo Habkost , Marcel Apfelbaum , Philippe =?utf-8?Q?Mathi?= =?utf-8?Q?eu-Daud=C3=A9?= , Yanan Wang , "Michael S. Tsirkin" , Richard Henderson , Ani Sinha , Peter Xu , Cornelia Huck , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Eric Blake , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, Michael Roth , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang Subject: Re: [PATCH v5 49/65] i386/tdx: handle TDG.VP.VMCALL In-Reply-To: <8a2c760d-6310-42eb-b632-5f67b12e2149@intel.com> (Xiaoyao Li's message of "Thu, 29 Feb 2024 18:54:48 +0800") References: <20240229063726.610065-1-xiaoyao.li@intel.com> <20240229063726.610065-50-xiaoyao.li@intel.com> <87a5nj1x4l.fsf@pond.sub.org> <8a2c760d-6310-42eb-b632-5f67b12e2149@intel.com> Date: Thu, 29 Feb 2024 14:28:51 +0100 Message-ID: <87wmqnwga4.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Xiaoyao Li writes: > On 2/29/2024 4:40 PM, Markus Armbruster wrote: >> Xiaoyao Li writes: >> >>> From: Isaku Yamahata >>> >>> Add property "quote-generation-socket" to tdx-guest, which is a property >>> of type SocketAddress to specify Quote Generation Service(QGS). >>> >>> On request of GetQuote, it connects to the QGS socket, read request >>> data from shared guest memory, send the request data to the QGS, >>> and store the response into shared guest memory, at last notify >>> TD guest by interrupt. >>> >>> command line example: >>> qemu-system-x86_64 \ >>> -object '{"qom-type":"tdx-guest","id":"tdx0","quote-generation-socket":{"type": "vsock", "cid":"1","port":"1234"}}' \ >>> -machine confidential-guest-support=tdx0 >>> >>> Note, above example uses vsock type socket because the QGS we used >>> implements the vsock socket. It can be other types, like UNIX socket, >>> which depends on the implementation of QGS. >>> >>> To avoid no response from QGS server, setup a timer for the transaction. >>> If timeout, make it an error and interrupt guest. Define the threshold of >>> time to 30s at present, maybe change to other value if not appropriate. >>> >>> Signed-off-by: Isaku Yamahata >>> Codeveloped-by: Chenyi Qiang >>> Signed-off-by: Chenyi Qiang >>> Codeveloped-by: Xiaoyao Li >>> Signed-off-by: Xiaoyao Li >> >> [...] >> >>> diff --git a/qapi/qom.json b/qapi/qom.json >>> index cac875349a3a..7b26b0a0d3aa 100644 >>> --- a/qapi/qom.json >>> +++ b/qapi/qom.json >>> @@ -917,13 +917,19 @@ >>> # (base64 encoded SHA384 digest). (A default value 0 of SHA384 is >>> # used when absent). >>> # >>> +# @quote-generation-socket: socket address for Quote Generation >>> +# Service (QGS). QGS is a daemon running on the host. User in >>> +# TD guest cannot get TD quoting for attestation if QGS is not >>> +# provided. So admin should always provide it. >> >> This makes me wonder why it's optional. Can you describe a use case for >> *not* specifying @quote-generation-socket? > > Maybe at last when all the TDX support lands on all the components, attestation will become a must for a TD guest to be usable. > > However, at least for today, booting and running a TD guest don't require attestation. So not provide it, doesn't affect anything excepting cannot get a Quote. Maybe # @quote-generation-socket: Socket address for Quote Generation # Service (QGS). QGS is a daemon running on the host. Without # it, the guest will not be able to get a TD quote for # attestation. [...]