Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D543AC7618D for ; Thu, 6 Apr 2023 06:17:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8187520B; Thu, 6 Apr 2023 08:16:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8187520B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680761841; bh=ASY1jWuYe/b/63rHkQDTUVbp0U8YHyGmxikNcuRnHaI=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=clbGdf/yNAHjrZxKq2020wcsPatn2H09B/v0OQgUZsxjgXdxM5ieQ42RLSrub12l9 A/rLoLG38PZIDbCoTIH1+Ffz/KxkA/sIePgFZYsnuipSuFlZ7/s72yn2v3cEZjlOYv TvDV+sJoJz7GRWkwaUrGw+AcBcjuktKfUzdz5LrY= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E960FF80246; Thu, 6 Apr 2023 08:16:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 290CFF80246; Thu, 6 Apr 2023 08:16:06 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B453BF8015B for ; Thu, 6 Apr 2023 08:16:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B453BF8015B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cg3vLrte; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5C1sek4l Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 55ABC22370; Thu, 6 Apr 2023 06:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680761761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AiJv7Q7qnbENvKxGsjQqRCguU/0BUfYyQ4lczevHbwo=; b=Cg3vLrtej9/My6xyBB2Wf5Q+bBPJEzZPvg7l7b4mJ99P76feJWFh9iUw83u2/lgPvqeajJ jFSvVpU3Hq3P+iysZiq1cUe4qWddrl8sC3/FsK7GjLWwghRhgi8b6Ng6GTG2kZKA0Y92Pn 4KaI/lexar+04vg9d4DU1QK+XicA8p0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680761761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AiJv7Q7qnbENvKxGsjQqRCguU/0BUfYyQ4lczevHbwo=; b=5C1sek4lpvHn+K7y2ZWSs4WYM7rw+C9Xm17ojSbkGqxjneufpe3WRVONxo1etZKBDv7D9y 841YCD0ewT8FxOAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 356E2133E5; Thu, 6 Apr 2023 06:16:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yjMECqFjLmRnIgAAMHmgww (envelope-from ); Thu, 06 Apr 2023 06:16:01 +0000 Date: Thu, 06 Apr 2023 08:16:00 +0200 Message-ID: <87wn2pv8m7.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: emu10k1: don't create old pass-through playback device on Audigy In-Reply-To: <20230405201220.2197938-1-oswald.buddenhagen@gmx.de> References: <20230405201220.2197938-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: SSGBIVLE43JRZZA5LIC2QTCLTP23HTP7 X-Message-ID-Hash: SSGBIVLE43JRZZA5LIC2QTCLTP23HTP7 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 05 Apr 2023 22:12:20 +0200, Oswald Buddenhagen wrote: > > It could have never worked, as snd_emu10k1_fx8010_playback_prepare() and > snd_emu10k1_fx8010_playback_hw_free() assume the emu10k1 offset for the > ETRAM, and the default DSP code includes no handler for it. It also > wouldn't make a lot of sense to make it work, as Audigy has an own, much > simpler, pass-through mechanism. So just skip creation of the device. > > Signed-off-by: Oswald Buddenhagen Applied, thanks. Takashi