Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lYiRn-0004QG-T1 for mharc-grub-devel@gnu.org; Tue, 20 Apr 2021 00:57:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYiRm-0004Oy-Gs for grub-devel@gnu.org; Tue, 20 Apr 2021 00:57:14 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:46598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYiRj-0003WO-Tq for grub-devel@gnu.org; Tue, 20 Apr 2021 00:57:14 -0400 Received: by mail-pl1-x636.google.com with SMTP id s20so3161805plr.13 for ; Mon, 19 Apr 2021 21:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=vezi3PJ51HsYSr/0SDnmyLiBCStid2jvJ/N8Brmkpko=; b=CJaKIf2ubcelFFfx30Nm5MJdxRlfwXv/WYyly5m5CSTqYKlkDqloUPg23Bp7pNJXRY L2exfNdCO25w4R/HVgSzwGLJHjlvdjwiWcRU+wfbGsompiML55f5pjd1HANBsn0ufeLj KnmABbmjO7lUgpmu/GmZzWqIlly8XTEy1IhEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=vezi3PJ51HsYSr/0SDnmyLiBCStid2jvJ/N8Brmkpko=; b=Fz+iYF7pbimT3YqWbpcS5DjxzrrM8WbACkI+SyDHGGsgIDP9uzuaxndVK4FPWm5LdD I94pbjLl9bWvo9sFSBkzrCTHalyDDadENmOy6E6FX9YHHhwSJu0Lo8YpcGYCWmvgsw0U Z0dOMo5cwbgve7hfXZ1Bu6XpHZSbLugeajFv5QxY+ZkjswPO4wcKyIJ8QwCCvM0pKyfP VRJe/kt9cx7DfSSGvwt/hGQtUj5boArdrg8B7sEWTEB92gnjN8l0E1kxgCkg8aL9skn6 4Wbd95d2YZW5WwxpWrTys78tTEOpkaIpvjEpH4hG2RuG7mB/tQ7heg/88nUxvB9tz8FT dZNg== X-Gm-Message-State: AOAM533ori4zayEKGkC5y8QnpDlykE/m+ZkAgTV25hotU5xidnAfr8wb OhD2dOdAY+KdyP2vYDvb0bu3zvKh4KZpfw== X-Google-Smtp-Source: ABdhPJyn1u0vA4DNpqV2KDWm7iAHYu3cej1dQq1uiV0m0ToX2bRrqvHZ9F8lPL2AukaiLPed2iqqWQ== X-Received: by 2002:a17:902:714e:b029:eb:a5fa:3ad2 with SMTP id u14-20020a170902714eb02900eba5fa3ad2mr23101097plm.44.1618894630042; Mon, 19 Apr 2021 21:57:10 -0700 (PDT) Received: from localhost (2001-44b8-1113-6700-10d0-1d8a-db99-2737.static.ipv6.internode.on.net. [2001:44b8:1113:6700:10d0:1d8a:db99:2737]) by smtp.gmail.com with ESMTPSA id i9sm1102403pjh.9.2021.04.19.21.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 21:57:09 -0700 (PDT) From: Daniel Axtens To: grub-devel@gnu.org Cc: ruscur@russell.cc Subject: Re: [PATCH 3/3] ieee1275: request memory with ibm, client-architecture-support In-Reply-To: <20210419170256.3434868-4-dja@axtens.net> References: <20210419170256.3434868-1-dja@axtens.net> <20210419170256.3434868-4-dja@axtens.net> Date: Tue, 20 Apr 2021 14:57:06 +1000 Message-ID: <87wnsxzh7h.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=dja@axtens.net; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 04:57:14 -0000 > diff --git a/grub-core/kern/ieee1275/cmain.c b/grub-core/kern/ieee1275/cmain.c > index 20cbbd761ec3..35f2c573730f 100644 > --- a/grub-core/kern/ieee1275/cmain.c > +++ b/grub-core/kern/ieee1275/cmain.c > @@ -90,7 +90,10 @@ grub_ieee1275_find_options (void) > } > > if (rc >= 0 && grub_strncmp (tmp, "IBM", 3) == 0) > - grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_NO_TREE_SCANNING_FOR_DISKS); > + { > + grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_NO_TREE_SCANNING_FOR_DISKS); > + grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_CAN_TRY_CAS_FOR_MORE_MEMORY); > + } There's a bug here, I use /model to set the flag, not /compatible. The test just has to move down in the function a bit. I'll send a new spin in a couple of days once anyone interested has a chance to look at the patch. Sorry about that, thought I had checked it, not quite sure what went wrong. Daniel