Return-Path: Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id i7sm19387803wrv.12.2020.12.14.07.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 07:01:07 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E6DCE1FF7E; Mon, 14 Dec 2020 15:01:06 +0000 (GMT) References: <20201125213617.2496935-1-keithp@keithp.com> <873608vde9.fsf@linaro.org> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Keith Packard Cc: qemu-devel@nongnu.org, Alistair Francis , Bastian Koppelmann , Laurent Vivier , Palmer Dabbelt , Peter Maydell , qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Sagar Karandikar Subject: Re: [PATCH 0/8] Add RISC-V semihosting 0.2. Finish ARM semihosting 2.0 Date: Mon, 14 Dec 2020 14:58:12 +0000 In-reply-to: <873608vde9.fsf@linaro.org> Message-ID: <87wnxktost.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: NYVI0ekIZYe2 Alex Benn=C3=A9e writes: > Keith Packard writes: > >> This series adds support for RISC-V Semihosting, version 0.2 as >> specified here: >> >> https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2 >> >> This specification references the ARM semihosting release 2.0 as specifi= ed here: >> >> https://static.docs.arm.com/100863/0200/semihosting.pdf >> >> That specification includes several semihosting calls which were not >> previously implemented. This series includes implementations for the >> remaining calls so that both RISC-V and ARM versions are now complete. >> >> Tests for release 2.0 can be found in picolibc on the semihost-2.0-all >> branch: >> >> https://github.com/picolibc/picolibc/tree/semihost-2.0-all >> >> These tests uncovered a bug in the SYS_HEAPINFO implementation for >> ARM, which has been fixed in this series as well. >> >> The series is structured as follows: >> >> 1. Move shared semihosting files >> 2. Change public common semihosting APIs >> 3. Change internal semihosting interfaces >> 4. Fix SYS_HEAPINFO crash on ARM >> 5. Add RISC-V semihosting implementation >> 6-8. Add missing semihosting operations from release 2.0 >> >> Signed-off-by: Keith Packard > > Queued to semihosting/next, thanks. Hmm scratch that... it fails in a number of linux-user only builds with: /usr/bin/ld: libqemu-aarch64_be-linux-user.fa.p/linux-user_aarch64_cpu_lo= op.c.o: in function `cpu_loop': /builds/stsquad/qemu/build/../linux-user/aarch64/cpu_loop.c:133: undefine= d reference to `do_common_semihosting' collect2: error: ld returned 1 exit status [651/2871] Compiling C object libqemu-alpha-linux-user.fa.p/target_alpha_= translate.c.o ninja: build stopped: subcommand failed. As well as a chunk of the various cross builds, see: https://gitlab.com/stsquad/qemu/-/pipelines/229443833/failures On the next re-spin could you include Kito Cheng's patch for linux-user support and also drop the version numbering from the commit titles so I don't have to file them off again. Thanks, --=20 Alex Benn=C3=A9e