Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kef6L-00063l-Uf for mharc-qemu-trivial@gnu.org; Mon, 16 Nov 2020 09:03:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kef6A-00062U-MQ for qemu-trivial@nongnu.org; Mon, 16 Nov 2020 09:03:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kef63-0004Sk-3A for qemu-trivial@nongnu.org; Mon, 16 Nov 2020 09:03:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605535385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oTDRJawd+ErdKluXBd8KinOsYZMKSD9G+kc59cOL08w=; b=IeFFl50UWLjLKEDj1cVY691D4MeJZ8uU4ofcOlfzfgVNpvz3klByopbtCu6VVTPtla/+9n uTZpVc6pJoFsOK1SU5F6cJzB5Pco2rVKoGFi1y1JTlq3j/QevmeC6td5wUZ4Jvvm9ztncb Yv7k1TyJmboKhS4OtaPhZsXNZ7BQk1k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-Go394t8oOFCguxsC98UEjw-1; Mon, 16 Nov 2020 09:03:03 -0500 X-MC-Unique: Go394t8oOFCguxsC98UEjw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C2C61017DC6; Mon, 16 Nov 2020 14:03:02 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBC9B610AF; Mon, 16 Nov 2020 14:03:01 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6D93911358BA; Mon, 16 Nov 2020 15:03:00 +0100 (CET) From: Markus Armbruster To: Alex Chen Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "qemu-trivial@nongnu.org" , "Chenqun (kuhn)" , "qemu-devel@nongnu.org" , Zhanghailiang Subject: Re: [PATCH v2] json: Fix a memleak in parse_pair() References: <20201113145525.85151-1-alex.chen@huawei.com> <7412CDE03601674DA8197E2EBD8937E83BA6762C@dggemm511-mbs.china.huawei.com> <87eektkdjw.fsf@dusky.pond.sub.org> <895daa42-e241-ff9c-6f55-a369ccfe9eb9@redhat.com> <5FB27D08.2070600@huawei.com> Date: Mon, 16 Nov 2020 15:03:00 +0100 In-Reply-To: <5FB27D08.2070600@huawei.com> (Alex Chen's message of "Mon, 16 Nov 2020 21:22:16 +0800") Message-ID: <87wnylieln.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 04:46:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2020 14:03:16 -0000 Alex Chen writes: > On 2020/11/16 19:43, Philippe Mathieu-Daud=C3=A9 wrote: >> On 11/16/20 7:42 AM, Markus Armbruster wrote: >>> "Chenqun (kuhn)" writes: >>> >>>>> -----Original Message----- >>>>> From: Chenzhendong (alex) >>>>> Sent: Friday, November 13, 2020 10:55 PM >>>>> To: armbru@redhat.com >>>>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org= ; >>>>> qemu-trivial@nongnu.org; Zhanghailiang ; >>>>> Chenqun (kuhn) >>>>> Subject: [PATCH v2] json: Fix a memleak in parse_pair() >>>>> >>>>> In qobject_type(), NULL is returned when the 'QObject' returned from >>>>> parse_value() is not of QString type, and this 'QObject' memory will = leaked. >>>>> So we need to first cache the 'QObject' returned from parse_value(), = and finally >>>>> free 'QObject' memory at the end of the function. >>>>> Also, we add a testcast about invalid dict key. >>>>> >>>>> The memleak stack is as follows: >>>>> Direct leak of 32 byte(s) in 1 object(s) allocated from: >>>>> #0 0xfffe4b3c34fb in __interceptor_malloc (/lib64/libasan.so.4+0x= d34fb) >>>>> #1 0xfffe4ae48aa3 in g_malloc (/lib64/libglib-2.0.so.0+0x58aa3) >>>>> #2 0xaaab3557d9f7 in qnum_from_int >>>>> /Images/source_org/qemu_master/qemu/qobject/qnum.c:25 >>>>> #3 0xaaab35584d23 in parse_literal >>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:511 >>>>> #4 0xaaab35584d23 in parse_value >>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:554 >>>>> #5 0xaaab35583d77 in parse_pair >>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:270 >>>>> #6 0xaaab355845db in parse_object >>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:327 >>>>> #7 0xaaab355845db in parse_value >>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:546 >>>>> #8 0xaaab35585b1b in json_parser_parse >>>>> /Images/source_org/qemu_master/qemu/qobject/json-parser.c:580 >>>>> #9 0xaaab35583703 in json_message_process_token >>>>> /Images/source_org/qemu_master/qemu/qobject/json-streamer.c:92 >>>>> #10 0xaaab355ddccf in json_lexer_feed_char >>>>> /Images/source_org/qemu_master/qemu/qobject/json-lexer.c:313 >>>>> #11 0xaaab355de0eb in json_lexer_feed >>>>> /Images/source_org/qemu_master/qemu/qobject/json-lexer.c:350 >>>>> #12 0xaaab354aff67 in tcp_chr_read >>>>> /Images/source_org/qemu_master/qemu/chardev/char-socket.c:525 >>>>> #13 0xfffe4ae429db in g_main_context_dispatch >>>>> (/lib64/libglib-2.0.so.0+0x529db) >>>>> #14 0xfffe4ae42d8f (/lib64/libglib-2.0.so.0+0x52d8f) >>>>> #15 0xfffe4ae430df in g_main_loop_run (/lib64/libglib-2.0.so.0+0x= 530df) >>>>> #16 0xaaab34d70bff in iothread_run >>>>> /Images/source_org/qemu_master/qemu/iothread.c:82 >>>>> #17 0xaaab3559d71b in qemu_thread_start >>>>> /Images/source_org/qemu_master/qemu/util/qemu-thread-posix.c:519 >>>>> >> ... >>> >>> Queued, thanks! >>=20 >> If possible can you s%/Images/source_org/qemu_master/qemu/%% to make >> description more readable...? >>=20 > > Hi Philippe, > I am sorry for that, considering that the patch has been queued, > do I need to modify the commit message and send patch v3? I'll take care of it, no need to respin. Thanks!