Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389EAC10DCE for ; Tue, 24 Mar 2020 03:53:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD98420714 for ; Tue, 24 Mar 2020 03:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="ks3YCF8m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD98420714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48mcmr3DKBzDqjJ for ; Tue, 24 Mar 2020 14:53:48 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48mcl26LK6zDqnG for ; Tue, 24 Mar 2020 14:52:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ks3YCF8m; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48mcl21mB7z9sRf; Tue, 24 Mar 2020 14:52:14 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1585021934; bh=RJoMJcdEMljLlcgenVS1+yDtyidHq9++WOTh4gTO7/8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ks3YCF8mjYCIDw3SKt/+CoLOF3tmApRgq9fWTfYO9ofvvhgrwUTsqilIZ464phb4N C+kY767lRBbAhJPo596YgBhtJNz+ivzTbPPP4YseBO1HXGdRaHvrXAHBxewy21Fzm3 94bL3prLkZ6t9hDy5RE0NeHSDsQ0fAMUao/0PPieZ6Owwen/rE+OU0/ZA8sLD02SSY kFyJRi2NrDFQH34uoblEwqmzO9AhxvtNKaWkXnbwuG8wmsQLdZ7zojPz7/j2e7gKNl abBVZ+hKwk6XZ91+YoG7HIuIR9yJ/1fzZO6p8AVwN5sQmPhZcXDzTPnsvrD2FPB39u TbLfVbRgAYY8w== From: Michael Ellerman To: "Naveen N. Rao" , Balamuruhan S , Segher Boessenkool Subject: Re: [PATCH] powerpc xmon: drop the option `i` in cacheflush In-Reply-To: <1584968594.gguy53jubt.naveen@linux.ibm.com> References: <20200323112548.1077440-1-bala24@linux.ibm.com> <20200323124630.GP22482@gate.crashing.org> <1584968594.gguy53jubt.naveen@linux.ibm.com> Date: Tue, 24 Mar 2020 14:52:21 +1100 Message-ID: <87wo7axvd6.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jniethe5@gmail.com, linuxppc-dev@lists.ozlabs.org, sandipan@linux.ibm.com, paulus@samba.org, ravi.bangoria@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" "Naveen N. Rao" writes: > Segher Boessenkool wrote: >> On Mon, Mar 23, 2020 at 04:55:48PM +0530, Balamuruhan S wrote: >>> Data Cache Block Invalidate (dcbi) instruction implemented in 32-bit >>> designs prior to PowerPC architecture version 2.01 and got obsolete >>> from version 2.01. We still support 32-bit ... >> It was added back in 2.03. It also exists in 64-bit designs (using >> category embedded), in 2.07 still even. > > Indeed, it has been part of Book3e. > > It isn't clear if this is still useful in this context (xmon) though, > since 'dcbf' seems to be equivalent in most respects. At the very least, > we should restrict this to Book3e, if it is of value there. Looking at the ISA it looks like dcbf is more or less equivalent and we could probably drop the explicit invalidate command. But the simplest option is probably to just ifdef it out for PPC_BOOK3S_64. cheers