From: Eric Anholt Subject: Re: [PATCH] drm/msm/dpu: Add UBWC support for RGB8888 formats Date: Thu, 07 Nov 2019 09:30:50 -0800 Message-ID: <87wocbiofp.fsf@anholt.net> References: <20191106232553.76553-1-frkoenig@google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1987673359==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark , Fritz Koenig Cc: Sean Paul , linux-arm-msm , freedreno , dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1987673359== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Rob Clark writes: > On Wed, Nov 6, 2019 at 3:26 PM Fritz Koenig wrote: >> >> Hardware only natively supports BGR8888 UBWC. >> UBWC support for RGB8888 can be had by pretending >> that the buffer is BGR. > > Just to expand, this aligns with how we handle RGB component order in > mesa for tiled or tiled+ubwc. If uncompressed to linear the component > order is RGB, but in tiled or tiled+ubwc, the component order is > always the hw "native" order (BGR) regardless of what the outside > world thinks. But that detail kinda doesn't matter, it's not like > generic code is going to understand the tiled or tiled+ubwc format in > the first place.. and code that does understand it, knows enough to > know that tiled/tiled+ubwc is always in the native component order. > >> Signed-off-by: Fritz Koenig > > Reviewed-by: Rob Clark Seems like a reasonable workaround to me, and permissible by our fourcc modifier rules ("you just have to have one way to address the pixels given a fourcc and a modifier"). Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAl3EVMoACgkQtdYpNtH8 nuizTw/9FlTG19QgaCUdQ4TnHR4KS0aHUTewrapoe5LZ96DKl4JAKdkzdT7oGaWq jIX26+6DpG6WF3VWqYBG1j9or0m+lZZGxAb548KpcDlW3N7HJh226acI12AGV1M4 GbiJKlsSosYtn1+OsvaXHQILN1+kBgoXbGrYq5FBIakAJ/E/lSp4r89U0mPAQu5H OBooVqdOZTzE6wf2VAuxW/Wi7PUuHQ5ba1CkUJYj3/3uyyy+X7dKAhKuknTksnMQ 35PpPXB9qyt5DIC0j2DG4htxzvAIMzhy/WYw6KWqFKFkCqHCn9JfZQokob+VK2az JXBosScS1tfx7+Rzdjk3ACzJXgjqRSPSKHkfclDRujXL0K2bDEdCl4Os68RyaFtn 0aiSpcdhTEMdxmP8vm3gUHrQSokHU1ZMGot6BvwSZO3WqT7BM3vGCIriWbGmvdbu zGWuCxSE8LqTnDNBGAgvI8tNfYw0dO/E73J+ARCrq5dniqHrNAahXquZKQQSVKbX zGIIpXamrlp6EXyeDu4ljxqKMo6FQFJUSMc9tKY9Us4KOAB2lgoSDwf9F5GYZk7+ 113gqrWzUFEV1oQZnuHnYTF24J784uzoEwxjAD11C0+JQ1s9PTpe44As0iJiUiq7 D7e1pPWOBmpd1Ej5YrOalr7Qn7IUyPTVrahc9GPZ5377VYEoZdo= =0F+3 -----END PGP SIGNATURE----- --=-=-=-- --===============1987673359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1987673359==--