Received: from eggs.gnu.org ([209.51.188.92]:39953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBHfw-0004DW-RG for qemu-devel@nongnu.org; Tue, 02 Apr 2019 07:33:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBHfv-00017s-SG for qemu-devel@nongnu.org; Tue, 02 Apr 2019 07:33:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33094) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBHfv-000140-KJ for qemu-devel@nongnu.org; Tue, 02 Apr 2019 07:33:55 -0400 From: Markus Armbruster References: <20190402085521.17973-1-chen.zhang@intel.com> Date: Tue, 02 Apr 2019 13:33:51 +0200 In-Reply-To: <20190402085521.17973-1-chen.zhang@intel.com> (Zhang Chen's message of "Tue, 2 Apr 2019 16:55:21 +0800") Message-ID: <87wokcd4kg.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] qapi/migration.json: Clean up for COLOStatus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen Cc: Zhang Chen , "Dr. David Alan Gilbert" , Juan Quintela , Markus Armbruster , Eric Blake , qemu-dev Zhang Chen writes: > From: Zhang Chen > > Address Markus's comments change the 'last_mode' to 'last-mode'. > > Signed-off-by: Zhang Chen > --- > qapi/migration.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index cfde29acf8..9217886c80 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1380,7 +1380,7 @@ > # @mode: COLO running mode. If COLO is running, this field will return > # 'primary' or 'secondary'. > # > -# @last_mode: COLO last running mode. If COLO is running, this field > +# @last-mode: COLO last running mode. If COLO is running, this field > # will return same like mode field, after failover we can > # use this field to get last colo mode. (since 4.1) > # > @@ -1389,7 +1389,7 @@ > # Since: 3.1 > ## > { 'struct': 'COLOStatus', > - 'data': { 'mode': 'COLOMode', 'last_mode': 'COLOMode', > + 'data': { 'mode': 'COLOMode', 'last-mode': 'COLOMode', > 'reason': 'COLOExitReason' } } > > ## Reviewed-by: Markus Armbruster Queued for 4.0 with the commit message tweaked to just qapi/migration.json: Rename COLOStatus last_mode to last-mode Hope that's okay. Thank you!