Received: from eggs.gnu.org ([2001:4830:134:3::10]:52339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXlHO-0007jz-J7 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:19:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXlHL-0008T0-Es for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:19:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXlHL-0008Sl-9d for qemu-devel@nongnu.org; Fri, 04 Sep 2015 03:19:19 -0400 From: Markus Armbruster References: <1441290623-13631-1-git-send-email-armbru@redhat.com> <1441290623-13631-31-git-send-email-armbru@redhat.com> <55E8B288.3090700@redhat.com> <20150904000405.10296.82922@loki> Date: Fri, 04 Sep 2015 09:19:16 +0200 In-Reply-To: <20150904000405.10296.82922@loki> (Michael Roth's message of "Thu, 03 Sep 2015 19:04:05 -0500") Message-ID: <87wpw6hcsr.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org Michael Roth writes: > Quoting Eric Blake (2015-09-03 15:50:16) >> On 09/03/2015 08:30 AM, Markus Armbruster wrote: >> > qapi/introspect.json defines the introspection schema. It's designed >> > for QMP introspection, but should do for similar uses, such as QGA. >> >> [review to follow in separate message; I'm using this message to focus >> on one point for easier tracking of the sub-thread] >> >> > >> > The introspection schema does not reflect all the rules and >> > restrictions that apply to QAPI schemata. A valid QAPI schema has an >> > introspection value conforming to the introspection schema, but the >> > converse is not true. >> > >> > Introspection lowers away a number of schema details, and makes >> > implicit things explicit: >> > >> > * The built-in types are declared with their JSON type. >> > >> > TODO Should we map all the integer types to just int? >> >> So, given the discussion on v3, I think we will have consensus if v5 >> does the following: >> >> - Merge 30 and 31 into a single patch, and drop this TODO statement (I >> think we have agreement that exposing QMP [that is, JSON number] wire >> form, with no additional constraints, as a single 'int', rather than the >> underlying generated C types, is the way to go), provided that... >> - Document in the qapi side that the schema intentionally lacks details >> on ranges, and that consulting the qapi and/or C code may be required to >> see what actual values are valid anywhere introspection merely says 'int', Please review docs/qapi-code-gen.txt in this patch for this aspect. >> - leave 32 as a separate patch, as it is complex enough, and still may >> have debate on whether the types '123' and 'int' should have >> corresponding array types '[123]' and '[int]' rather than the v3 patch >> munging of '456' and '789' (I haven't yet reviewed whether v4 changed that). > > Agreed on all 3 Excellent. >> Any further arguments on whether exposing just 'int' in the >> introspection for all integral types, and/or whether patches 30 and 31 >> should be merged, are best made in response to this mail. > > Given the above, I don't think I have any further objections. Thanks!