From: Eric Anholt Subject: Re: [PATCH 4/6] drm/i915: Add an interface to dynamically change the cache level Date: Wed, 30 Mar 2011 09:59:55 -0700 Message-ID: <87wrjg4k8k.fsf@pollan.anholt.net> References: <1301443195-10721-1-git-send-email-eric@anholt.net> <1301443195-10721-5-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0296431572==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0296431572== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 30 Mar 2011 08:09:47 +0100, Chris Wilson = wrote: > The series looks really good, only one quibble below. >=20 > On Tue, 29 Mar 2011 16:59:53 -0700, Eric Anholt wrote: > > +int i915_gem_object_set_cache_level(struct drm_i915_gem_object *obj, > > + enum i915_cache_level cache_level) > > + if (cache_level =3D=3D I915_CACHE_NONE) { > > + /* If we're coming frm LLC cached, then we haven't > > + * actually been tracking whether the data is in the > > + * CPU cache or not, since we only allow one bit set > > + * in obj->write_domain. Just set it to the CPU cache > > + * for now. > > + */ > > + BUG_ON(obj->base.write_domain & I915_GEM_GPU_DOMAINS); > > + obj->base.write_domain =3D I915_GEM_DOMAIN_CPU; > > + } >=20 > [We can rearrange the code to convert the BUG_ON into a > if (WARN_ON()) return -EBUSY;.] >=20 > I think this is overkill, at least by my interpretation of the old BLT > docs which imply that cache line invalidation (both CPU and GPU) is done > for snooped PTEs on MI_FLUSH. And what about a CPU write through the GTT? Or the CPU writes to the pages before we turned them into a BO and cleared their CPU write domain flag without actually clflushing them? --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk2TYYsACgkQHUdvYGzw6vfJ2QCfd/uYoGWC0YmZTrxqXbDW7WKl yKcAn0SyBdgbDIEvEd+sWRppjJggq05L =N6V4 -----END PGP SIGNATURE----- --=-=-=-- --===============0296431572== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0296431572==--