Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtMHg-0004QA-K5 for qemu-devel@nongnu.org; Thu, 01 Oct 2009 10:05:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtMHb-0004Nm-Cw for qemu-devel@nongnu.org; Thu, 01 Oct 2009 10:05:27 -0400 Received: from [199.232.76.173] (port=41464 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtMHb-0004Ni-3M for qemu-devel@nongnu.org; Thu, 01 Oct 2009 10:05:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58699) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtMHY-0007TZ-QW for qemu-devel@nongnu.org; Thu, 01 Oct 2009 10:05:21 -0400 Subject: Re: [Qemu-devel] [PATCH 2/2] hw/omap_dma: add matching {} in if 0 References: <20091001055144.GC5068@redhat.com> <87pr976z82.fsf@pike.pond.sub.org> <20091001131048.GA9820@redhat.com> From: Markus Armbruster Date: Thu, 01 Oct 2009 16:05:16 +0200 In-Reply-To: <20091001131048.GA9820@redhat.com> (Michael S. Tsirkin's message of "Thu\, 1 Oct 2009 15\:10\:48 +0200") Message-ID: <87ws3f5hwj.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Blue Swirl , qemu-devel@nongnu.org "Michael S. Tsirkin" writes: > On Thu, Oct 01, 2009 at 03:05:49PM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > MULTI_REQ is never defined, so it doesn't matter much, but since we have >> > an if statement there, let's add {} to clarify what it should do if it's >> > uncommented. >> > >> > Signed-off-by: Michael S. Tsirkin >> > --- >> > hw/omap_dma.c | 4 +++- >> > 1 files changed, 3 insertions(+), 1 deletions(-) >> > >> > diff --git a/hw/omap_dma.c b/hw/omap_dma.c >> > index 205d010..ab5e925 100644 >> > --- a/hw/omap_dma.c >> > +++ b/hw/omap_dma.c >> > @@ -588,7 +588,7 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma) >> > #ifdef MULTI_REQ >> > /* TODO: should all of this only be done if dma->update, and otherwise >> > * inside omap_dma_transfer_generic below - check what's faster. */ >> > - if (dma->update) >> > + if (dma->update) { >> > #endif >> > >> > /* If the channel is element synchronized, deactivate it */ >> > @@ -670,6 +670,8 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma) >> > * bits on it. */ >> > #ifndef MULTI_REQ >> > } >> > +#else >> > + } >> > #endif >> > >> > omap_dma_interrupts_update(s); >> >> Doesn't this look silly? Just close the brace :) > > This way we get more {'s than }'s, which is even more ugly. > We probably should indent the text within if (dma->update) though. I'd just kill the dead code, keep only the TODO comment.