Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19EBAC77B7C for ; Thu, 20 Apr 2023 12:49:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A7B16ED1; Thu, 20 Apr 2023 14:48:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A7B16ED1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1681994943; bh=cMws2fis6674crVV6z3zHznzxguegBS3bD1YNxXSp+E=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=L9TIKGegSyls+BjHk42+xhfk9zxtqVAywd8b6kyJwQHuZQ9WeetQu78zQpRA9VirQ YKAaI45Wn6SK2K+2yfPxmsbXKsvwE07i4K/vvm2eyDKXdmJ8GA92dptn9Blb4CRyg9 JzMNR5l2AAyV/fBAS1jpTEGgS8s+a8BI0rMTxS4o= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B56E3F80510; Thu, 20 Apr 2023 14:47:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D377F80510; Thu, 20 Apr 2023 14:47:53 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E82E7F80212 for ; Thu, 20 Apr 2023 14:47:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E82E7F80212 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OL+JdFDa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7eYfxLUL Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 15015219BC; Thu, 20 Apr 2023 12:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681994869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HTHVxC2svPLzFMYH3+XJMZqe+9MlRBDvNzhqZDJydEU=; b=OL+JdFDahCY0X8OvjO6In0dXXP3+NpRH6UhcLcJqIsYvE7Bjb4QAhFl0PDv6A8dh1zoF31 aEJZDbCU4Fky8hPzOxPzDztQBa7Q4c2uQCWs5k67LEL74p2imbrQ9u6aBJdXGa9607INmF RSOzlks+mhY7oaQCBuNXH/0IPQstNt8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681994869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HTHVxC2svPLzFMYH3+XJMZqe+9MlRBDvNzhqZDJydEU=; b=7eYfxLULu24E+hk8KjtQs9V30YDcgAiYa6wWJVu30KwiK75YXjPJpHfG4VB5Z+gHZE2Vd1 WKJzm8cRspLhLqBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E3BAA1333C; Thu, 20 Apr 2023 12:47:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UpheNnQ0QWSVBQAAMHmgww (envelope-from ); Thu, 20 Apr 2023 12:47:48 +0000 Date: Thu, 20 Apr 2023 14:47:48 +0200 Message-ID: <87y1mmu3d7.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH v2] docs: sound/kernel-api/writing-an-alsa-driver.rst: polishing In-Reply-To: <20230420114341.878441-1-oswald.buddenhagen@gmx.de> References: <20230420114341.878441-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 67254H6REJ3BWNH3TIGD4U7EBEBAUXUU X-Message-ID-Hash: 67254H6REJ3BWNH3TIGD4U7EBEBAUXUU X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 20 Apr 2023 13:43:41 +0200, Oswald Buddenhagen wrote: > > - Update some outdated info > - Language fixes > - Whitespace/formatting fixes > - Prefer attached over stand-alone '::' > > Signed-off-by: Oswald Buddenhagen > > --- > > v2: > - dropped questionable hunk from period timer example code > - new hunk: improved wording wrt period sizes Looks better, but I don't like putting FIXME's in the end result: > Callbacks are not atomic > ~~~~~~~~~~~~~~~~~~~~~~~~ > > -All these three callbacks are basically not atomic. > +All these three callbacks are basically (FIXME: but ...?) not atomic. You can omit the word "basically" and replace "not atomic" with "non-atomic". > +``SNDRV_DMA_TYPE_DEV_SG`` in the PCM constructor like for other PCI > +pre-allocations. You need to pass ``&pci->dev``, where pci is > +the struct pci_dev pointer of the chip as well:: > > snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV_SG, > &pci->dev, size, max); > > +// FIXME: dma_private again I don't understand what are you asking here. "dma_private" has been already described in the early section. thanks, Takashi