Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2672C7618D for ; Thu, 6 Apr 2023 06:13:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 652EF1FA; Thu, 6 Apr 2023 08:12:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 652EF1FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680761608; bh=iKRdQSlSYeo4KpI+IY7Wn2kP5GeIUqbM/ZgRY91JvJM=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mOg0ERnt/DPxxJLAOkZSKIJd+LMtn2tx8MwAzIAsQSuQPKJYikHrf3zD+RgT9MsRX aOcUmIACYfL2Dwf+KnEfCbCRny71XhyIf6Jia8CmCNOz2WcGk9Pm12kh/bdDxs1UHO UqdvOJ6E1bV2zXzOcaBqN5/DRYSIzwM6cc0RMPcg= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3F24AF80246; Thu, 6 Apr 2023 08:12:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 37709F80246; Thu, 6 Apr 2023 08:12:13 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2F5E9F80149 for ; Thu, 6 Apr 2023 08:12:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2F5E9F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=blOTVesC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=BMgwcwTd Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D267B22591; Thu, 6 Apr 2023 06:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680761528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FGKNWqy2msyR6/Vy8cqKEan2kj5i3DubsXstEtNzcLE=; b=blOTVesCzrCBZdkVfPzsxvg6H1m6XVYGjcjTUZt4SZpH2/e3R41Vuxf3z+c4sRJ4FVTp2E Fpn1VWDidA9zKRj09OabmwO2GuGx1Wsif+ZmJwfvvnZraDN9RTQzSJ9o8wgZ1wpGAc7jjo flGDWvxEPyqwnIyWLJk7jN8TayvrxUk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680761528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FGKNWqy2msyR6/Vy8cqKEan2kj5i3DubsXstEtNzcLE=; b=BMgwcwTd0eX7LG5uZpz2fWGuaNYsQaU+fWCOtBXDS8ymXAaM8vRLVSh5YvyB7lZmUdaoHr iEHInM1DPqj8OvBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B8EE7133E5; Thu, 6 Apr 2023 06:12:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rjVjLLhiLmSzIAAAMHmgww (envelope-from ); Thu, 06 Apr 2023 06:12:08 +0000 Date: Thu, 06 Apr 2023 08:12:08 +0200 Message-ID: <87y1n5v8sn.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: emu10k1: fix capture interrupt handler unlinking In-Reply-To: <20230405201220.2197923-1-oswald.buddenhagen@gmx.de> References: <20230405201220.2197923-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: BTNIYJTPVDS6WXI7FDAFPTFKODYAUWXM X-Message-ID-Hash: BTNIYJTPVDS6WXI7FDAFPTFKODYAUWXM X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 05 Apr 2023 22:12:20 +0200, Oswald Buddenhagen wrote: > > Due to two copy/pastos, closing the MIC or EFX capture device would > make a running ADC capture hang due to unsetting its interrupt handler. > In principle, this would have also allowed dereferencing dangling > pointers, but we're actually rather thorough at disabling and flushing > the ints. > > While it may sound like one, this actually wasn't a hypothetical bug: > PortAudio will open a capture stream at startup (and close it right > away) even if not asked to. If the first device is busy, it will just > proceed with the next one ... thus killing a concurrent capture. > > Signed-off-by: Oswald Buddenhagen Applied, thanks. Takashi