Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7C5C4332F for ; Fri, 21 Oct 2022 13:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbiJUNEq (ORCPT ); Fri, 21 Oct 2022 09:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiJUNEp (ORCPT ); Fri, 21 Oct 2022 09:04:45 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 413F84B0CA for ; Fri, 21 Oct 2022 06:04:43 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id b4so4801218wrs.1 for ; Fri, 21 Oct 2022 06:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ub/Q3aGASlrAXKX6JbBno3sJc5izj2B9kHx5Vfj31no=; b=gEJ6INl1uo2EhdrqvpQPhIeMhpnTp/XTU+JHgRvsZWO7q0dliF+YoqCWZGjqTDPHmV NZH1YUUL4hRBFfUiUbBxtJlGJEGGhg+dCZZ5CXddKxrwdK8Y/zY35MWxxyY+6rJdfWjg CnbFzh/3uiviFDfs2zHAudI3cY/42hpKZeJehUUk9xx3FSp3PBuGwS/5p4sFoknG0opI gVV94ui6Y5m95IH2FzeDetax+EyO183Vv4HjyeOnWa/m0s6DKjbB4cyPxwYDCFH386sI xHdi6c3J+arK/FjKtZNzt6ZtvYDD8D58x/R8xf4TT33C6TWaVCThCozrmMCQ0Arl9o/Y x6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ub/Q3aGASlrAXKX6JbBno3sJc5izj2B9kHx5Vfj31no=; b=n1e/ppCP/S3EkttOfGJRbAl2O/6kObqryHFljiS8ElkSrNjkbr29LLks4DGSYII5GO I4fwXou5PEqNf4l3wSLAhtZ5gn6bRZ6HgjncjzIcAo4Kx0tnGfR37Uvu2JwA/i8kQR5f IhH9fZGi+E0wfDkkVq7tEj34piaaFv5VBBtAeHFmWlUgw+Dniotk5kg6sRSP2N2u1a24 ft/4Lch8ltVWmoH87KfafqH2bxZCwpDiqyZMiljBWgzYhPTCAGBRa/Ck2oSxoO1jwV/4 uosGtnygkPyqpYKPVSO+Ap37YxFu09DVfXdRnweOmssrAjUwnh6P0ffOQ2vv3CsNDPNJ RAtA== X-Gm-Message-State: ACrzQf14r2o0h00pZ3t5Lsj3G6qejFVtkkYSC4IyBVzhhtgFXTLSsLt2 5yYR6mjEJBwTLhRFbfVTv5/ZoA== X-Google-Smtp-Source: AMsMyM7Upp2advF48Gmvc7xuqXWi5BXIj28tAi5l0CGstD4rPMbCg2nWp/QDAkA7mw9jbyrpjk+Z9w== X-Received: by 2002:adf:fa05:0:b0:22e:362a:ce57 with SMTP id m5-20020adffa05000000b0022e362ace57mr12200802wrr.96.1666357481661; Fri, 21 Oct 2022 06:04:41 -0700 (PDT) Received: from localhost ([2a01:cb19:8b2c:5e00:becf:29f6:2774:7ce2]) by smtp.gmail.com with ESMTPSA id c5-20020a05600c0a4500b003bdd2add8fcsm2878337wmq.24.2022.10.21.06.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 06:04:41 -0700 (PDT) From: Mattijs Korpershoek To: Colin Ian King , Dmitry Torokhov , linux-input@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: tps6507x-ts: remove variable loops In-Reply-To: <20221020181642.24417-1-colin.i.king@gmail.com> References: <20221020181642.24417-1-colin.i.king@gmail.com> Date: Fri, 21 Oct 2022 15:04:39 +0200 Message-ID: <87y1t9pbtk.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Oct 20, 2022 at 19:16, Colin Ian King wrote: > The variable loops is being incremented but is never referenced, > it is redundant and can be removed. > > Signed-off-by: Colin Ian King Reviewed-by: Mattijs Korpershoek > --- > drivers/input/touchscreen/tps6507x-ts.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c > index 357a3108f2e5..f48871767763 100644 > --- a/drivers/input/touchscreen/tps6507x-ts.c > +++ b/drivers/input/touchscreen/tps6507x-ts.c > @@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc, > static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc) > { > s32 ret; > - s32 loops = 0; > u8 val; > > ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG, > @@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc) > ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val); > if (ret) > return ret; > - loops++; > } > > return ret; > -- > 2.37.3