Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66F3B10E0F5 for ; Fri, 22 Apr 2022 16:08:36 +0000 (UTC) Date: Fri, 22 Apr 2022 09:07:51 -0700 Message-ID: <87y1zx6qzs.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Anshuman Gupta In-Reply-To: <20220422125912.6862-1-anshuman.gupta@intel.com> References: <20220422125912.6862-1-anshuman.gupta@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t] lib/intel_device_info: Add IS_DGFX() support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Rodrigo Vivi Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 22 Apr 2022 05:59:12 -0700, Anshuman Gupta wrote: > > Currently IGT is lacking IS_DGFX() macro support. > There are some power features like D3Cold are only > supported on discrete card. So IGT test/tools specific > to D3Cold requires to consume IS_DGFX(). > Adding a is_dgfx field in intel_device_info and initializing > it for DG1. All future discrete platform would require to > initialize this field. #define IS_DGFX(fd) gem_has_lmem(fd) ? gem_has_lmem() is already pretty widely used so maybe we should not introduce another way to achieve the same goal?