Content-Type: multipart/mixed; boundary="===============5591899725415191052==" MIME-Version: 1.0 From: Thomas Gleixner To: kbuild-all@lists.01.org Subject: Re: [PATCH] x86/entry: Fix noinstr violation Date: Thu, 08 Jul 2021 20:37:30 +0200 Message-ID: <87y2agodn9.ffs@nanos.tec.linutronix.de> In-Reply-To: <87a6mxorjp.ffs@nanos.tec.linutronix.de> List-Id: --===============5591899725415191052== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Jul 08 2021 at 15:37, Thomas Gleixner wrote: > The recent commit which fixed the entry/exit mismatch on failed 32-bit > syscalls got the ordering vs. instrumentation_end() wrong, which makes > objtool complain about tracer invocation in an instrumentation disabled > region. > > Stick the offending local_irq_disable() into the instrumentation enabled > region so objtool stops complaining. > > Fixes: 5d5675df792f ("x86/entry: Fix entry/exit mismatch on failed fast 3= 2-bit syscalls") Bah. I looked at the wrong branch. It's fixed already in Linus tree: commit 240001d4e3041832e8a2654adc3ccf1683132b92 Author: Peter Zijlstra Date: Mon Jun 21 13:12:34 2021 +0200 x86/entry: Fix noinstr fail in __do_fast_syscall_32() Though that lacks a CC: stable tag, which would have been appropriate because 5d5675df792f ("x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls") has been backported. Can the stable folks pick this up please? Thanks, tglx --===============5591899725415191052==--