Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBBECC433DB for ; Fri, 29 Jan 2021 11:45:53 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AC7C64E06 for ; Fri, 29 Jan 2021 11:45:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AC7C64E06 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DRwWw3CGzzDqLR for ; Fri, 29 Jan 2021 22:45:48 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DRwQq5fcDzDrhn for ; Fri, 29 Jan 2021 22:41:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=R81CIsQ7; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4DRwQh2FfCz9s1l; Fri, 29 Jan 2021 22:41:16 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1611920481; bh=xzHILf+29xPZ0aQ6YxqaatCYkWf8taJuwJRNrFUdFnM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=R81CIsQ71oN+2wG2HJbeXjtDGytU9PT1DGw/3VnLzkUjN2VNI5KJz3T0OpP4FfWfs aiUppaWH87mHCLyV70ca1YTg/L0vmmwdhlF+53OMHhqGKCPtgoiBqyp8kajeuDS7xJ 9eZzbYj4hyee+qwTCd4Xph3V9bgHx7m0yGEuBTbuLJ5yxD+d5TYQHtDRGIDxLZmMaw KOEjI5y7L5G6oXtRL6oBRS/Jf9jWOQ8U2u1w2ReBe9wbdipfRE/dZeemqmztFTsobs zk1j5L0sOUFVNB+ZtbG0tRseTq4TFhWcR68Ag6GuIpLjDtyxbx2JWRKIXUFuO36+n/ 8yt1mfsWHcVWg== From: Michael Ellerman To: Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev Subject: Re: [PATCH 1/2] powerpc/vdso: fix unnecessary rebuilds of vgettimeofday.o In-Reply-To: References: <20201223171142.707053-1-masahiroy@kernel.org> Date: Fri, 29 Jan 2021 22:41:15 +1100 Message-ID: <87y2gcc6n8.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ravi Bangoria , Linux Kernel Mailing List , Nicholas Piggin , Oliver O'Halloran , Greentime Hu , Michal Suchanek , Ard Biesheuvel , Daniel Axtens Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Masahiro Yamada writes: > On Thu, Dec 24, 2020 at 2:12 AM Masahiro Yamada wrote: >> >> vgettimeofday.o is unnecessarily rebuilt. Adding it to 'targets' is not >> enough to fix the issue. Kbuild is correctly rebuilding it because the >> command line is changed. >> >> PowerPC builds each vdso directory twice; first in vdso_prepare to >> generate vdso{32,64}-offsets.h, second as part of the ordinary build >> process to embed vdso{32,64}.so.dbg into the kernel. >> >> The problem shows up when CONFIG_PPC_WERROR=y due to the following line >> in arch/powerpc/Kbuild: >> >> subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror >> >> In the preparation stage, Kbuild directly visits the vdso directories, >> hence it does not inherit subdir-ccflags-y. In the second descend, >> Kbuild adds -Werror, which results in the command line flipping >> with/without -Werror. >> >> It implies a potential danger; if a more critical flag that would impact >> the resulted vdso, the offsets recorded in the headers might be different >> from real offsets in the embedded vdso images. >> >> Removing the unneeded second descend solves the problem. >> >> Link: https://lore.kernel.org/linuxppc-dev/87tuslxhry.fsf@mpe.ellerman.id.au/ >> Reported-by: Michael Ellerman >> Signed-off-by: Masahiro Yamada >> --- > > > Michael, please take a look at this. > > The unneeded rebuild problem is still remaining. Sorry missed those. I guess I'll pick these up as fixes for v5.10. cheers