From: Thomas Gleixner Subject: Re: [PATCH 00/18] genirq: Remove setup_irq() Date: Thu, 27 Feb 2020 11:31:15 +0100 Message-ID: <87y2somido.fsf@nanos.tec.linutronix.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ynAR1FfssG9UvbQNF4vSnFz9Qe0K3E5jRaYKFF5aOCA=; b=qyMKGmeW50JgPW 8VuYJXSnwhZSvRwWaRROaORI0usatvKl03L4GDZLUPpt30cKtrpNqaNLEtNX1wA7z9wOkQGQQ6fyP k4+0OFq/cQKvQJPSTHdDRvcVZbPyOsPZ+D+343OAvmumbzSvkQ52nqVOrxFRmRjH9TyG0kkwVr0MW Lwnesrhk9qi3+eGvAMLPgQJw5rlkmCJpbZOXJWzEUnoc6+XNV0WQlP5K33dgezyG/Sa4WyLHsCDOF VwRsg4aq0Qayd78y4c8Id/OLjk0or/qHrda2yxm543kD7ct7wwg/tF1UW29Ocwj11efTpPvxAZG3u 3M28dwf/nt3gOyuPb4lA==; In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: afzal mohammed , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, x86@kernel.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-ia64@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-omap@vger.kernel.org, linux-alpha@vger.kernel.org Cc: Julia Lawall , Michal Marek , Nicolas Palix , Gilles Muller Afzal, afzal mohammed writes: > While trying to understand internals of irq handling, came across a > thread [1] in which tglx was referring to avoid usage of setup_irq(). > Existing callers of setup_irq() reached mostly via 'init_IRQ()' & > 'time_init()', while memory allocators are ready by 'mm_init()'. > > Hence instances of setup_irq() is replaced by request_irq() & > setup_irq() (along with remove_irq()) definition deleted in the last > patch. > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). thanks a lot for tackling this! Vs. merging this series, I suggest the following approach: - Resubmit the individual changes as single patches or small series to the relevant maintainers and subsystem mailing lists. They have no dependency on a core change and can be applied where they belong to. - After 5.6-rc6, verify which parts have made their way into linux-next and resubmit the ignored ones as a series to me along with the removal of the core parts. That way we can avoid conflicting changes between subsystems and the tip irq/core branch as much as possible. Thanks, tglx