Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CD2C43603 for ; Wed, 18 Dec 2019 14:31:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A8BD218AC for ; Wed, 18 Dec 2019 14:31:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="R9bHKdkY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727067AbfLRObz (ORCPT ); Wed, 18 Dec 2019 09:31:55 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:25565 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726955AbfLRObz (ORCPT ); Wed, 18 Dec 2019 09:31:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576679514; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=P/lRJXDpwvquBLYiWhxlFgz3L+OSvpwUpcFblI1zh14=; b=R9bHKdkYAiBPc/QPjTE6H6nWeUtbLFiiX1jjSKWp3E/xh2j5RAfy0czy0CS3OnBp6dFj/EwE 4Y5hj+Xix8ccx+jC2EDw/EDvRrn6CQiVqWmW932eFv4vgGNx4SlZM7Hp6P/3st5sulinpiuT lkU/9Q9LlNVfjSirIKg5AxlvSpo= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5dfa3856.7fdcaf050c00-smtp-out-n01; Wed, 18 Dec 2019 14:31:50 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 64147C4479C; Wed, 18 Dec 2019 14:31:50 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C93E7C43383; Wed, 18 Dec 2019 14:31:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C93E7C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Kalle Valo Cc: Maya Erez , Ahmad Masri , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com Subject: Re: [PATCH 1/8] wil6210: dump Rx status message on errors References: <20191218135947.5903-1-merez@codeaurora.org> <20191218135947.5903-2-merez@codeaurora.org> <87v9qd917e.fsf@kamboji.qca.qualcomm.com> Date: Wed, 18 Dec 2019 16:31:45 +0200 In-Reply-To: <87v9qd917e.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 18 Dec 2019 16:07:33 +0200") Message-ID: <87y2v93dta.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Maya Erez writes: > >> From: Ahmad Masri >> >> Dump all the Rx status message on different errors to allow more >> visibility of the case. >> >> Signed-off-by: Ahmad Masri >> Signed-off-by: Maya Erez >> --- >> drivers/net/wireless/ath/wil6210/txrx_edma.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/wil6210/txrx_edma.c b/drivers/net/wireless/ath/wil6210/txrx_edma.c >> index 02548d40253c..6a1671c3a2be 100644 >> --- a/drivers/net/wireless/ath/wil6210/txrx_edma.c >> +++ b/drivers/net/wireless/ath/wil6210/txrx_edma.c >> @@ -903,6 +903,11 @@ static struct sk_buff *wil_sring_reap_rx_edma(struct wil6210_priv *wil, >> if (unlikely(!wil_val_in_range(buff_id, 1, wil->rx_buff_mgmt.size))) { >> wil_err(wil, "Corrupt buff_id=%d, sring->swhead=%d\n", >> buff_id, sring->swhead); >> + print_hex_dump(KERN_ERR, "RxS ", DUMP_PREFIX_OFFSET, 16, 1, >> + (void *)msg, wil->use_compressed_rx_status ? > > Isn't the cast unnecessary? Please avoid casting as much as possible. > >> @@ -963,6 +968,11 @@ static struct sk_buff *wil_sring_reap_rx_edma(struct wil6210_priv *wil, >> >> if (unlikely(dmalen > sz)) { >> wil_err(wil, "Rx size too large: %d bytes!\n", dmalen); >> + print_hex_dump(KERN_ERR, "RxS ", DUMP_PREFIX_OFFSET, 16, 1, >> + (void *)msg, wil->use_compressed_rx_status ? > > Same here. I fixed these in the pending branch, please double check: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=51d652cdee36051bdb83809adb91951f41c7a456 -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches