Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A213C43613 for ; Mon, 24 Jun 2019 09:05:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 537F32083D for ; Mon, 24 Jun 2019 09:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 537F32083D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfKuJ-00065e-Ba for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 05:04:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48534) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfKrR-0003hq-4K for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfKrJ-0000fK-MU for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:01:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfKrJ-0007yQ-AH; Mon, 24 Jun 2019 05:01:53 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B2EC5D619; Mon, 24 Jun 2019 09:01:28 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-169.ams2.redhat.com [10.36.117.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 328231001B04; Mon, 24 Jun 2019 09:01:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9ABD511386A3; Mon, 24 Jun 2019 10:57:24 +0200 (CEST) From: Markus Armbruster To: Suraj Jitindar Singh References: <20190501053522.10967-1-sjitindarsingh@gmail.com> <1561078267.4771.6.camel@gmail.com> Date: Mon, 24 Jun 2019 10:57:24 +0200 In-Reply-To: <1561078267.4771.6.camel@gmail.com> (Suraj Jitindar Singh's message of "Fri, 21 Jun 2019 10:51:07 +1000") Message-ID: <87y31rtl6z.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 24 Jun 2019 09:01:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, dgilbert@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Suraj Jitindar Singh writes: > On Wed, 2019-05-01 at 15:35 +1000, Suraj Jitindar Singh wrote: >> Add a monitor command "dump-stack" to be used to dump the stack for >> the >> current cpu. > > To summarise the discussion which occured on this patch, > > - It looks like it's ok to duplicate this functionality as it provides > an easier method to achieve this in the field and also for development. By "duplicate", do you mean "one copy in gdb, one copy in QEMU"? The question "why can't we simply hot-add a gdb server and use gdb?" has not been answered as far as I can tell. If the answer is "we can, but we find duplicating the functionality in QEMU more convenient", then the next question is "okay, but is the convenience worth the additional code?". For PPC, the additional code is fairly small. What about more ornery targets like x86_64? This hasn't been answered, either. > - It's ok for this to remain as a separate command and to not place it > as a subcommand under info. I strongly prefer "info FOO" for "pure" information-retrieving commands. But I'm not the maintainer anymore. > I'll rework based on the comments on 2/2 of the series and resend.