From: Thiago Jung Bauermann Date: Tue, 18 Jun 2019 23:05:26 +0000 Subject: Re: [PATCH v4 3/6] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls Message-Id: <87y31y7avd.fsf@morokweng.localdomain> List-Id: References: <20190528064933.23119-1-bharata@linux.ibm.com> <20190528064933.23119-4-bharata@linux.ibm.com> In-Reply-To: <20190528064933.23119-4-bharata@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bharata B Rao Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, paulus@au1.ibm.com, aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com, linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com, cclaudio@linux.ibm.com Hello Bharata, Bharata B Rao writes: > diff --git a/arch/powerpc/include/asm/kvm_book3s_hmm.h b/arch/powerpc/include/asm/kvm_book3s_hmm.h > index 21f3de5f2acb..3e13dab7f690 100644 > --- a/arch/powerpc/include/asm/kvm_book3s_hmm.h > +++ b/arch/powerpc/include/asm/kvm_book3s_hmm.h > @@ -11,6 +11,8 @@ extern unsigned long kvmppc_h_svm_page_out(struct kvm *kvm, > unsigned long gra, > unsigned long flags, > unsigned long page_shift); > +extern unsigned long kvmppc_h_svm_init_start(struct kvm *kvm); > +extern unsigned long kvmppc_h_svm_init_done(struct kvm *kvm); > #else > static inline unsigned long > kvmppc_h_svm_page_in(struct kvm *kvm, unsigned long gra, > @@ -25,5 +27,15 @@ kvmppc_h_svm_page_out(struct kvm *kvm, unsigned long gra, > { > return H_UNSUPPORTED; > } > + > +static inine unsigned long kvmppc_h_svm_init_start(struct kvm *kvm) > +{ > + return H_UNSUPPORTED; > +} > + > +static inine unsigned long kvmppc_h_svm_init_done(struct kvm *kvm); > +{ > + return H_UNSUPPORTED; > +} > #endif /* CONFIG_PPC_UV */ > #endif /* __POWERPC_KVM_PPC_HMM_H__ */ This patch won't build when CONFIG_PPC_UV isn't set because of two typos: "inine" and the ';' at the end of kvmppc_h_svm_init_done() function prototype. -- Thiago Jung Bauermann IBM Linux Technology Center