Received: from eggs.gnu.org ([209.51.188.92]:46510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMFeM-00072Z-D4 for qemu-devel@nongnu.org; Thu, 02 May 2019 13:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMFeL-0005mk-BH for qemu-devel@nongnu.org; Thu, 02 May 2019 13:37:38 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:55138) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMFeL-0005lX-4L for qemu-devel@nongnu.org; Thu, 02 May 2019 13:37:37 -0400 Received: by mail-wm1-x342.google.com with SMTP id b10so4011254wmj.4 for ; Thu, 02 May 2019 10:37:36 -0700 (PDT) References: <20190502084506.8009-1-thuth@redhat.com> <20190502084506.8009-2-thuth@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20190502084506.8009-2-thuth@redhat.com> Date: Thu, 02 May 2019 18:37:34 +0100 Message-ID: <87y33o4v1d.fsf@zen.linaroharston> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 1/7] tests/qemu-iotests/005: Add a sanity check for large sparse file support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Fam Zheng , qemu-block@nongnu.org, Christophe Fergeau , Ed Maste , Kevin Wolf , Max Reitz , Li-Wen Hsu , Philippe =?utf-8?Q?M?= =?utf-8?Q?athieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Eric Blake , Markus Armbruster Thomas Huth writes: > "check -raw 005" fails when running on certain filesystems - these do not > support such large sparse files. Use the same check as in test 220 to > skip the test in this case. > > Suggested-by: Eric Blake > Reviewed-by: Eric Blake > Signed-off-by: Thomas Huth Reviewed-by: Alex Benn=C3=A9e > --- > tests/qemu-iotests/005 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005 > index 2fef63af88..9c7681c19b 100755 > --- a/tests/qemu-iotests/005 > +++ b/tests/qemu-iotests/005 > @@ -55,6 +55,15 @@ if [ "$IMGPROTO" =3D "sheepdog" ]; then > _notrun "image protocol $IMGPROTO does not support large image sizes" > fi > > +# Sanity check: For raw, we require a file system that permits the creat= ion > +# of a HUGE (but very sparse) file. Check we can create it before contin= uing. > +if [ "$IMGFMT" =3D "raw" ]; then > + if ! truncate --size=3D5T "$TEST_IMG"; then > + _notrun "file system on $TEST_DIR does not support large enough = files" > + fi > + rm "$TEST_IMG" > +fi > + > echo > echo "creating large image" > _make_test_img 5000G -- Alex Benn=C3=A9e