Received: from eggs.gnu.org ([2001:4830:134:3::10]:58354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHsh7-00076r-Vx for qemu-devel@nongnu.org; Wed, 31 Oct 2018 11:46:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHsh2-0007ar-AQ for qemu-devel@nongnu.org; Wed, 31 Oct 2018 11:46:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44176) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gHsh2-0007aU-4L for qemu-devel@nongnu.org; Wed, 31 Oct 2018 11:46:04 -0400 From: Markus Armbruster References: <1540365080-6844-1-git-send-email-liq3ea@gmail.com> <4d64d42a-8727-81aa-6015-a9db92abca76@redhat.com> Date: Wed, 31 Oct 2018 16:46:00 +0100 In-Reply-To: <4d64d42a-8727-81aa-6015-a9db92abca76@redhat.com> (Laszlo Ersek's message of "Wed, 24 Oct 2018 13:35:34 +0200") Message-ID: <87y3aep1af.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] fw_cfg_reboot: ensure reboot_time is nonegative List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Li Qiang , peter.maydell@linaro.org, pbonzini@redhat.com, qemu-devel@nongnu.org Laszlo Ersek writes: > On 10/24/18 09:11, Li Qiang wrote: >> This can avoid setting a negative value to >> etc/boot-fail-wait. >> >> Signed-off-by: Li Qiang >> --- >> hw/nvram/fw_cfg.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c >> index f4a52d8..276dcb1 100644 >> --- a/hw/nvram/fw_cfg.c >> +++ b/hw/nvram/fw_cfg.c >> @@ -199,12 +199,17 @@ static void fw_cfg_reboot(FWCfgState *s) >> reboot_timeout = strtol(p, &p, 10); >> } >> } >> - /* validate the input */ >> - if (reboot_timeout > 0xffff) { >> - error_report("reboot timeout is larger than 65535, force it to 65535."); >> - reboot_timeout = 0xffff; >> + >> + if (reboot_timeout >= 0) { >> + /* validate the input */ >> + if (reboot_timeout > 0xffff) { >> + error_report("reboot timeout is larger than 65535," >> + "force it to 65535."); >> + reboot_timeout = 0xffff; >> + } >> + fw_cfg_add_file(s, "etc/boot-fail-wait", >> + g_memdup(&reboot_timeout, 4), 4); >> } >> - fw_cfg_add_file(s, "etc/boot-fail-wait", g_memdup(&reboot_timeout, 4), 4); >> } >> >> static void fw_cfg_write(FWCfgState *s, uint8_t value) >> > > I don't feel strongly about fixing this issue. > > However, if we decide to fix it, we should start with the bare-bones > strtol() call, visible at the top of the context. I'm not up-to-date on > what's the best QEMU helper function for this, but I seem to remember it > checks for trailing garbage, and perhaps even for range. Maybe we should > even use a different (better) option parsing facility thatn > qemu_opt_get(). Adding Eric and Markus. Whenever we qemu_opt_get() a string, then convert it to a number ourselves, we're doing it wrong. Can you use qemu_opt_get_number()? When you have to convert string to integer, use the qemu_strtoX() that gives you the width and signedness you need. Or maybe one of the parse_uint*(). > Also, I would suggest forcing negative values (that were explicitly > specified) to some sensible positive default, such as 5 seconds or so. > > Thanks > Laszlo