Received: from eggs.gnu.org ([2001:4830:134:3::10]:35665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eihjP-00036j-UE for qemu-devel@nongnu.org; Mon, 05 Feb 2018 09:26:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eihjK-0007Qg-U7 for qemu-devel@nongnu.org; Mon, 05 Feb 2018 09:26:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37608) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eihjK-0007Q3-Nl for qemu-devel@nongnu.org; Mon, 05 Feb 2018 09:26:46 -0500 From: Markus Armbruster References: <20180202130336.24719-1-armbru@redhat.com> <20180202130336.24719-13-armbru@redhat.com> Date: Mon, 05 Feb 2018 15:26:38 +0100 In-Reply-To: (Marc-Andre Lureau's message of "Mon, 5 Feb 2018 14:45:26 +0100") Message-ID: <87y3k7v7fl.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc-Andre Lureau Cc: marcandre , qemu-devel , mdroth@linux.vnet.ibm.com Marc-Andre Lureau writes: > On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wro= te: >> Signed-off-by: Markus Armbruster > > It's not obvious the motivation behind this change (beside behind more > elegant), but At one point during my search for a good way to record includes in the parse tree, updating .exprs in two places got in the way, so I cleaned it up. I guess it's not in the way of the solution I eventually chose, but I consider it a worthwhile little cleanup on its own. > Reviewed-by: Marc-Andr=C3=A9 Lureau Thanks!