Received: from eggs.gnu.org ([2001:4830:134:3::10]:48702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axxGQ-0002a4-Ss for qemu-devel@nongnu.org; Wed, 04 May 2016 09:55:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axxGF-0000qt-Ax for qemu-devel@nongnu.org; Wed, 04 May 2016 09:54:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axxGF-0000ow-76 for qemu-devel@nongnu.org; Wed, 04 May 2016 09:54:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C234B3DD47 for ; Wed, 4 May 2016 13:54:31 +0000 (UTC) From: Markus Armbruster References: <1461879932-9020-1-git-send-email-eblake@redhat.com> <87twik3bx4.fsf@dusky.pond.sub.org> <572350A5.6050208@redhat.com> <87lh3wy32b.fsf@dusky.pond.sub.org> <57236AFD.7010702@redhat.com> Date: Wed, 04 May 2016 15:54:29 +0200 In-Reply-To: <57236AFD.7010702@redhat.com> (Eric Blake's message of "Fri, 29 Apr 2016 08:09:01 -0600") Message-ID: <87y47qlyi2.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspection cleanups subset E) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Uh, in visitor.h at the end of this series: * * Visitor *v; * Error *err = NULL; * int value; * * v = ...obtain visitor... * visit_start_struct(v, NULL, NULL, 0, &err); * if (err) { ---> goto outobj; * } * visit_start_list(v, "list", NULL, 0, &err); * if (err) { * goto outobj; * } * value = 1; * visit_type_int(v, NULL, &value, &err); * if (err) { * goto outlist; * } * value = 2; * visit_type_int(v, NULL, &value, &err); * if (err) { * goto outlist; * } * outlist: * visit_end_list(v); * if (!err) { * visit_check_struct(v, &err); * } * outobj: * visit_end_struct(v); * error_propagate(errp, err); * ...clean up v... * The ---> goto is wrong; we call visit_end_struct() after visit_start_struct() failed. Haven't dug through the patches to find the guilty one.